•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-13154-1 08 Mar 2023

Fixed.

HD-DEN-13154-1 08 Mar 2023

Fixed.

HD-DEN-13154-1 08 Mar 2023

Variable is also updated by receipts of DG flow broadcasts. I believe it is overridable on DG side.

HD-DEN-13154-1 08 Mar 2023

Fixed.

HD-DEN-13154-1 07 Mar 2023

Shouldnt this be set to 0U instead of 0.0F?

HD-DEN-13154-1 07 Mar 2023

This should be U32.

HD-DEN-13154-1 08 Mar 2023

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14689-1 08 Mar 2023

Fixed. Thanks!

HD-DEN-14830-2 06 Mar 2023

Why alarm if above low temp? I think >42 or > tgt+4 should be two ways to get same non-safety high temp alarm.
And I think <33 or < tgt-4 should be two ways to get same non-safety low temp alarm.
Did Systems want to separate these? My understanding was not to separate.

UI-DEN-14838-1 07 Mar 2023

typo: ajust => adjust

UI-DEN-14838-1 07 Mar 2023

in general, if the comment is for the entire if block put it in front of the if block.
also for the else at line 66.

UI-DEN-14838-1 07 Mar 2023

please move after the text property and remove the extra empty line.

UI-DEN-14838-1 07 Mar 2023

Didn't we find an issue with changing this to bool instead of alias while were testing?

HD-DEN-14689-1 08 Mar 2023

Add blank line before comment.

UI-DEN-14838-1 09 Mar 2023

This is after the text property. I removed the newline between them as a change

HD-DENBUG-101-1 20 Oct 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

HD-DEN-13154-1 08 Mar 2023

Concern was originally just for retract due to highest speed. We ended up reducing retract speed to reduce likelihood of stalls. Still a good idea to check for it though and since retract, preload and seek all share same relatively high speed, these are the ops that have the check. For bolus and continuous, should not stall at these speeds and would catch with rate alarm if it did.

UI-DEN-16526-3 03 Nov 2023

You're missing an n in the "clickDeboucing" same issue with the others

HD-DEN-14689-1 08 Mar 2023

FALSE will be determined by our automagic script to be ACK_REQUIRED in the excel sheet. This will cause discrepancies between the readers of that sheet and what the FW does.

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

HD-DEN-13154-1 08 Mar 2023

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-16391-1 27 Nov 2023

Space after if.

HD-DEN-13154-1 08 Mar 2023

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-13154-1 07 Mar 2023

Should we check for stall in bolus & continuous states?

LEAHI-TD-FIRMWARE-LDT-3126-1 26 Feb 2026

Still need to close valves.

HD-DEN-13154-1 08 Mar 2023

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-13154-1 07 Mar 2023

seems odd to create a variable just for it to be returned. Is this value supposed to be overridable?

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

HD-DEN-14689-1 08 Mar 2023

Fixed. Thanks!

HD-DEN-14689-1 08 Mar 2023

Fixed. Thanks!

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

I don't see fix.

HD-DEN-14689-1 08 Mar 2023

Fixed. Thanks!

DG-DEN-14689-1 08 Mar 2023

Fixed. Thanks!

DG-DEN-14689-1 02 Mar 2023

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

LEAHI-DIALIN-LEAH-139-3 06 Feb 2025

Fixed. Thanks!

HD-DEN-14689-1 08 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14830-2 27 Feb 2023

I thought the non-safety temp alarms had a large persistence. Now they have none?

HD-DEN-14830-2 27 Feb 2023

If you clear immediately, it will let you resume/clear alarm immediately (before temp comes back into range), but then alarm will re-trigger immediately (because temp is still out of range).

HD-DEN-14830-2 08 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DIALIN-DENBUG-163-1 07 Feb 2025

RESOLVED in CODE WALKTHROUGH

UI-DEN-14838-1 09 Mar 2023

It will display two same values with one tick.

I have removed the check.

UI-DEN-14838-1 09 Mar 2023

Moved onTextChanged line and removed extra newline

UI-DEN-14838-1 09 Mar 2023

Can you check on the latest commit if this space was already removed? I can't tell which line this comment is in regards to. Thanks!

HD-DEN-14689-1 09 Mar 2023

How do we wish to handle the output of the automated script? It currently does not handle conditional statements to determine ack requiredness.

If set to false, the output is:

0x4A MSG_ID_UI_PATIENT_DISCONNECTION_CONFIRM hdfirmware response COMM_BUFFER_OUT_CAN_HD_2_UI ACK_REQUIRED PAYLOAD

which is incorrect to what the code is doing. We have 2 different implementations of calling sendAckResponseMsg()


1. sendAckResponseMsg( (MSG_ID_T)message->hdr.msgID, COMM_BUFFER_OUT_CAN_HD_2_UI, FALSE );

  1. if we dont meet an expected condition. Later in the handler we will call a response message with the response message calling:
    serializeMessage( msg, COMM_BUFFER_OUT_CAN_DG_2_HD, ACK_REQUIRED );


2. sendAckResponseMsg( (MSG_ID_T)message->hdr.msgID, COMM_BUFFER_OUT_CAN_HD_2_UI, result );

  1. a conditional based on?


Please review the FW_Message_list.csv within latest develop & staging builds to understand how the automated script is determining "ack requireness"

HD-DEN-14689-1 08 Mar 2023

Add space after "(".

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

This is the target temperature from the TD.

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

DG should be DD.

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

both the original and last will be automatically updated once we have automated builds running.

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!