•  

Comment Results

Review Name Created Custom Fields Content
RO-LDT-566-1 30 Jun 2025

fixed. thanks!

RO-LDT-566-1 30 Jun 2025

fixed. thanks!

RO-LDT-566-1 30 Jun 2025

fixed. thanks!

RO-LDT-566-1 30 Jun 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

Is this value added in the Switches column intentionally?
We should avoid doing this if that is intentional.

LEAHI-APPLICATION-LDT-627-1 30 Jun 2025

Thanks for reminding me.
RESOLVED.

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

There is only a target rate in the payload for now. We would need to calculate this ourselves right now. to discuss with FW

LEAHI-SW-LDT-627-1 30 Jun 2025

align 0s and .value/s

LEAHI-SW-LDT-627-1 01 Jul 2025

I know.
But imagine you want to send what has already been adjusted without any slider change.
With your idea, you then have to move the slider to send a message, which may not be the same as the previous one, depending on your slider resolution and how difficult it is to set to the same value.

LEAHI-SW-LDT-627-1 01 Jul 2025

Not exactly what I meant, but it is fine.
RESOLVED

LEAHI-SW-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-SW-LDT-627-1 30 Jun 2025

align the commas

LEAHI-SW-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-SW-LDT-627-1 01 Jul 2025

Didn't notice.
RESOLVED

LEAHI-SW-LDT-627-1 30 Jun 2025

I don't remember if I did, but have you tested if we have any problem with the direct conversion of the bool to an unsigned integer?
shouldn't we convert it here with Qt conversion functions?

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1021-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

align .

LEAHI-APPLICATION-LDT-907-1 07 Jul 2025

add id/object name

LEAHI-APPLICATION-LDT-1636-1 15 Aug 2025

updated

LEAHI-APPLICATION-LDT-907-1 08 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-907-1 07 Jul 2025

add ObjectName. The object name for id: _root is not needed just the child componenets

LEAHI-APPLICATION-LDT-1636-1 15 Aug 2025

RESOLVED

UI-DEN-14909-1 13 Mar 2023

In C++ the trinary "?" operator will call both true and false sections and then will decide which to return.
If that is the case for the QML/JS I suggest using a function with an if block to return the decided object.
to ensure the trinary "?" operator behavior, you can use the "Component.onCompleted: {", if the new Qt 5.15 in-line Component declaration supports it.

UI-DEN-14909-1 13 Mar 2023

RESOLVED.

Thanks for the test, that is what I remembered.
Fine then

HD-DEN-16391-1 27 Nov 2023

Done.

UI-DEN-14909-1 13 Mar 2023

1 - The component instance has been used in the same file, and that is the new feature, and previously we have to create a file to use the component instance, or directly return the created component for one instance use.
2 - The Loader is used inside of the component, which doesn't seem right, the idea is to use inline components so, if possible, avoid loaders.
3 - Multiple components for the line tickmarks and round ones are created since it seems only a property change to make it rounded, since QML doesn't have a line or circle and all are Rectangle, it makes sense to update the underlying rectangle properties to get the desired shape.

HD-DEN-16391-1 27 Nov 2023

Done.

UI-DEN-17206-4 10 Feb 2025

RESOLVED

HD-DEN-16512-1 27 Nov 2023

Done.

DG-DEN-14646-1 14 Mar 2023

Per our alarms discussion it was decided that this alarm was no longer necessary.

HD-DEN-16512-1 28 Nov 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14906-1 15 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14906-1 15 Mar 2023

Per our re-prime slide deck, we wanted to change minimum ultrafiltration volume from zero to X mL. X = treatment duration (in hrs) x 100 mL. I think changes are in order in ModeTreatmentParams.c and perhaps elsewhere to implement that change.
Also, in Reservoirs.c, we will want to prevent dialysate use from being counted while in re-prime states.
Also, there were some alarms we wanted to exempt while performing re-prime.
Let me know if you'd like me to handle any of these parts of the implementation.

TD-LEAH-838-1 21 Feb 2025

Done.

HD-DEN-14906-1 16 Mar 2023

Fixed.

HD-DEN-16391-1 28 Nov 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14906-1 15 Mar 2023

Done

HD-DEN-16391-1 27 Nov 2023

Space after if.

HD-DEN-14906-1 15 Mar 2023

Done.

DG-DEN-14646-1 14 Mar 2023

Removed.

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

Ok, but still need to resolve first part of my comment. This is not an override for temperature value. It is override for the fpga read counter of the temperature sensor.

HD-DEN-14906-1 14 Mar 2023

The timer should have been 5 minutes, my mistake. The purpose is to prevent repeated triggering of the reprime after the 5 minute before treatment reprime is done, as you pointed out. If I change the 5 hours to 5 minutes, is that OK?

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

HD buttons?

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

DG should be DD.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

This looks more like a flow rate (mL/min) than a speed (RPM).

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

HD-DEN-14906-1 15 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14906-1 15 Mar 2023

RESOLVED in CODE WALKTHROUGH.