•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

DG should be DD.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Filtered pressure

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

TD-LEAH-838-1 21 Feb 2025

Done.

TD-LEAH-838-1 20 Feb 2025

Do we want to change STATE_CLOSED to CMN_TO_NO_OPEN (or similar?), STATE_OPEN to CMN _TO_NC_OPEN?

RO-LEAH-261-1 24 Feb 2025

Why is this necessary? Add comment if it is necessary.
Generally, we would want the responsible driver to initialize actuator set points in their init functions.

UI-DEN-17157-1 25 Feb 2025

Done

UI-DEN-17157-1 25 Feb 2025

Done

UI-DEN-17157-1 25 Feb 2025

Done

UI-DEN-17157-1 25 Feb 2025

please add //DEBUG: to comment this out.

UI-DEN-17157-1 25 Feb 2025

I believe you should correct the other z-orders.

RO-LEAH-273-1 05 Mar 2025

Fixed. Thanks!

RO-LEAH-273-1 04 Mar 2025

DDInterface.h

DG-DEN-14646-1 13 Mar 2023

Use #define for bit mask. Remove extra ";".

UI-DEN-16526-3 03 Nov 2023

Oh, I see, I am missing an "n".
Fixed

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

DG should be DD.

UI-DEN-16526-3 03 Nov 2023

RESOLVED in CODE WALKTHROUGH
you're welcome.

DG-DEN-14763-1 21 Mar 2023

Done

HD-DEN-14689-1 08 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14689-1 08 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16391-1 27 Nov 2023

Space between parenthesis.

UI-DEN-14838-1 09 Mar 2023

Updated, thank you

UI-DEN-14838-1 09 Mar 2023

Will make note. Changed comment to reflect.

DG-DEN-14646-1 13 Mar 2023

Is prefix guaranteed to not be zero?

DIALIN-DEN-14786-1 10 Mar 2023

Fixed. Thanks!

DIALIN-DEN-14786-1 10 Mar 2023

Remove blank line.

HD-DEN-14689-1 10 Mar 2023

DG no longer sends this message. We determine DG check-in by receiving the DG op mode command.

DIALIN-DEN-14786-1 10 Mar 2023

RESOLVED.

HD-DEN-14689-1 10 Mar 2023

Why removed?

HD-DEN-14689-1 10 Mar 2023

Has DG check-in msg ID been made available for re-purpose?
RESOLVED in CODE WALKTHROUGH.

HD-DEN-14689-1 08 Mar 2023

I think that's true in calls to serialize function, but I don't think this function wants this kind of flag (i.e. it's not looking for whether to require ACK or not - it wants to know if we are ACKing (TRUE) or NAKing (FALSE) this command). Here, we are NAKing the command, so FALSE was appropriate.

HD-DEN-14689-1 09 Mar 2023

Change cmd to prompt

HD-DEN-14689-1 10 Mar 2023

Isn't deleted statement correct?

HD-DEN-14689-1 10 Mar 2023

Isn't delete statement correct?

HD-DEN-14689-1 10 Mar 2023

Isn't deleted statement correct?

DG-DEN-14763-1 14 Mar 2023

Function header.

HD-DEN-14860-1 13 Mar 2023

Did Blaine ask for this?

DG-DEN-14646-1 13 Mar 2023

Why is this indented?

DG-DEN-14646-1 13 Mar 2023

A small thing, but 24V Main should come before first voltage.

HD-DEN-14689-1 08 Mar 2023

FALSE was right.

HD-DEN-14830-2 08 Mar 2023

Remove blank line.

UI-DEN-14909-1 13 Mar 2023

I believe this is leftover code that I missed from the slider bug fixes. I'll remove it for this branch.

UI-DEN-14909-1 13 Mar 2023

We had a discussion about what needed to be done and you had mentioned that the progressRect would be transparent. In order for that to be transparent, we needed a background rectangle color. BUT we had talked this morning and I will remove this rectangle and just set the progress rect's color as w/e the active color is.

UI-DEN-14909-1 13 Mar 2023

Ok, easy change over.

UI-DEN-14909-1 13 Mar 2023

We had this discussion this morning, I have already tested it also. It is working as we expected. It only prints out the round tick's Component.onCompleted log messages of the round tick marks and not both the round and lined tick marks. This is operating as we expected.

UI-DEN-14909-1 13 Mar 2023

Thanks,
Sorry for the confusion.
Yes, please, as we talked, the active progress should be orange, and the background I think can stay as it was.
Then you can remove that extra Rectangle.

DG-DEN-14763-1 14 Mar 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14763-1 14 Mar 2023

Function header.

DG-DEN-14763-1 14 Mar 2023

Function header.