•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

I dont want limit the methods to the enums like that.

  • it allows the method to work while the enum may be out of sync. ( good for debugging purposes )
  • it allows us to test the method by sending out of range paramaters to the FW and get the correct rejection(s).
LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

HD-DEN-16512-1 06 Dec 2023

Done.

TD-LEAH-838-1 21 Feb 2025

Removed TODO.

TD-LEAH-838-1 21 Feb 2025

Done.

UI-DEN-17157-1 25 Feb 2025

Done

UI-DEN-17157-1 25 Feb 2025

Done

DD-LEAH-224-1 24 Feb 2025

I would consider switching only to be the abnormal case, so better to say != TRUE.

DD-LEAH-224-1 24 Feb 2025

Why is there a max pressure? If looking for a drop, why not just a <= min?

DD-LEAH-224-1 24 Feb 2025

Why do we need 2 flags for pressure drop? Seems like you only use one at a time.

DD-LEAH-224-1 24 Feb 2025

Still needed?

UI-DEN-17157-1 25 Feb 2025

RESOLVED

UI-DEN-17157-1 25 Feb 2025

RESOLVED

UI-DEN-17157-1 25 Feb 2025

please align arguments.

DG-DEN-17234-1 27 Feb 2025

No

DG-DEN-17234-1 27 Feb 2025

Comment doesn't match test flag.

RO-LEAH-273-1 05 Mar 2025

Fixed To RO. Thanks!

RO-LEAH-273-1 05 Mar 2025

Fixed. Thanks!

RO-LEAH-273-1 05 Mar 2025

Fixed based on comment in DD interface. Changed back to private.

RO-LEAH-273-1 04 Mar 2025

Add comment or remove other comments for consistency.
Also, I've been naming this kind of function with prefix "signal" instead of "request" when a command is coming from another sub-system into the state machine.

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-DIALIN-LDT-566-1 25 Jun 2025

Should we be logging anything?

LEAHI-APPLICATION-LDT-1021-1 03 Jul 2025

fixed string

LEAHI-APPLICATION-LDT-1021-1 03 Jul 2025

Please consider defining a variable for functions that are used multiple times, like fields.size(), and then use that value afterwards.
But for now,
RESOLVED.

LEAHI-APPLICATION-LDT-627-1 03 Jul 2025

RESOLVED

LEAHI-SW-LDT-627-1 03 Jul 2025

RESOLVED

DD-LDT-815-1 03 Jul 2025

Mark these questions with TODO to aid in follow-up.

LEAHI-APPLICATION-LDT-1021-1 03 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1021-1 03 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 07 Jul 2025

created component for icons

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

make internal properties instead of marker alias

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

adjust height to make smaller and center items

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

removed

LEAHI-APPLICATION-LDT-853-1 11 Jul 2025

moved effect to modal dialog

LEAHI-APPLICATION-LDT-853-1 11 Jul 2025

done

LEAHI-APPLICATION-LDT-853-1 11 Jul 2025

done

LEAHI-APPLICATION-LDT-853-1 11 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1209-1 15 Jul 2025

Please fix the typo and align the two functions.

UI-DEN-14909-1 13 Mar 2023

Why was this Rectangle added?
the ProgressRect is a Rectangle and can be used for the active color, and the _progressRectBackground seems redundant.

HD-DEN-14906-1 15 Mar 2023

This was removed when the function was changed to solve other problems.

DD-LEAH-224-1 24 Feb 2025

Update @return comment.

HD-DEN-14860-1 15 Mar 2023

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14763-1 15 Mar 2023

Done.