•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

remove

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

remove and use modal Overlay.modal

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

Where is it being used?

LEAHI-APPLICATION-LDT-853-1 11 Jul 2025

RESOLVED.

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

Same

LEAHI-APPLICATION-LDT-1209-1 15 Jul 2025

added to Variables

LEAHI-APPLICATION-LDT-1636-1 15 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1636-1 15 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-2160-1 08 Sep 2025

file named to ValueAdjuster

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Why aren't we doing these checks anymore?

HD-DEN-14860-1 14 Mar 2023

Based on your comment in Teams:
@ Qd = 450 in your data set... ~8 seconds spent between drain and fill that suggests maybe our just-in-time is a bit off - maybe should have started fill immediately.

UI-DEN-17157-1 25 Feb 2025
  • same here as above.
  • same here as above.
HD-DEN-16512-1 27 Nov 2023

5% seems like a reasonable max step. I don't think we want to go to ramp up/down states if > 5% change. I think we just want to limit the change to max 5% for a single control interval.

HD-DEN-16512-1 28 Nov 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14906-1 15 Mar 2023

I am unfamiliar with all of those parts of the firmware, so it would probably be more efficient for you to do them.

HD-DEN-16391-1 28 Nov 2023

First letter (c) should be lower case.

HD-DEN-14906-1 15 Mar 2023

init function created for dialyzer reprime

HD-DEN-14906-1 15 Mar 2023

Need to reject a saline bolus request if re-prime is in progress.

HD-DEN-14906-1 14 Mar 2023

Might want to include DialyzerRePrime in these state function names for clarity (similar to saline bolus state function names).

HD-DEN-16391-1 28 Nov 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14763-1 15 Mar 2023

Done

DG-DEN-14763-1 15 Mar 2023

Done.

HD-DEN-16391-1 28 Nov 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16512-1 07 Dec 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16565-1 22 Dec 2023

Are these changes necessary? What do they do exactly?

LEAHI-APPLICATION-LDT-1636-1 18 Aug 2025

RESOLVED

HD-DEN-16565-1 22 Dec 2023

I don't see SystemComm calling this or reboot function. Why are they here?

LEAHI-TD-FIRMWARE-LDT-3126-1 26 Feb 2026

Add a blank line after declarations.

RO-LEAH-273-1 05 Mar 2025

I think thats in alphabetical?

RO-LEAH-273-1 04 Mar 2025

In RODefs.h, you have a standby pause state. Not sure why you think you'll need that, but if it is needed it should be here.

RO-LEAH-273-1 04 Mar 2025

Who would call this function? DD is calling handle function below, not this one. I think that handle function is only one calling this, so should be private (static).

RO-LEAH-273-1 04 Mar 2025

I believe this is already called by caller to this function (handleIncomingMessage in Messaging.c) when it returns, so this is redundant.

LEAHI-APPLICATION-LDT-1021-1 03 Jul 2025

Added notification to user

DD-LDT-815-1 03 Jul 2025

Add a TODO comment to complete when NV POST implemented.

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

updated to used Variable

LEAHI-APPLICATION-LDT-907-1 07 Jul 2025

user facing strings should be translated. Use qsTr("Information")

LEAHI-APPLICATION-LDT-853-1 08 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

RESOLVED.

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

Use ProgressBar instead and remove marker and move value to the right to look like the saline progress bar

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

added back in

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

removed alias and created properties

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

move to modal dialog if not created

LEAHI-APPLICATION-LDT-853-1 11 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

updated

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

RESOLVED