•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-14763-1 16 Mar 2023

RESOLVED IN CODE WALKTHROUGH

LEAHI-APPLICATION-LDT-907-1 07 Jul 2025

Do not think this property is needed since the Label component already has this property set

HD-DEN-16391-1 28 Nov 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16391-1 27 Nov 2023

Space after if.

UI-DEN-17157-2 25 Feb 2025

RESOLVED

UI-DEN-17157-1 25 Feb 2025

please remove extra space before DRY_...

UI-DEN-17157-1 25 Feb 2025

Make it like GridSelection.qml @ L54.

LEAHI-TD-FIRMWARE-LDT-3126-1 27 Feb 2026

Added back

UI-DEN-17157-1 25 Feb 2025

RESOLVED

UI-DEN-17157-1 25 Feb 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 03 Jul 2025

RESOLVED

LEAHI-BOOTLOADER-LDT-3259-1 27 Feb 2026

We can't jump to app if fpga ID is bad? Why not?

LEAHI-TD-FIRMWARE-LDT-3126-1 27 Feb 2026

Removed

DD-LDT-815-1 03 Jul 2025

Done.

LEAHI-TD-FIRMWARE-LDT-1903-8 27 Feb 2026

duty misspelled.

DD-LDT-815-1 03 Jul 2025

Removed.

DD-LDT-815-1 03 Jul 2025

Keep a blank line between banner and variables.

LEAHI-TD-FIRMWARE-LDT-3126-1 26 Feb 2026

We do not always want to return to run state. If we were in ramp state prior to pause state, we would want to go back to ramp state here.
So you need to remember your previous state in a new variable.

LEAHI-DD-FIRMWARE-LDT-3372-2 02 Mar 2026

added

LEAHI-DD-FIRMWARE-LDT-3372-2 02 Mar 2026

These are correct variable names based on their coefficient names in calculations of conductivity.

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

updated to remove background color

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

removed for now

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

RESOLVED.

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1636-1 15 Aug 2025

updated

LEAHI-TD-FIRMWARE-LDT-3126-1 02 Mar 2026

I should have said "before test messages" instead of "first". But where you put them is fine so I will resolve.

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

Will look into next branch for integration of components and backend

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

create a fontSize instead of alias

LEAHI-TESTSUITES-LDT-2839-1 03 Mar 2026

made changes as per comment

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

it looks like we already have cpp code to log it

LEAHI-APPLICATION-LDT-853-1 11 Jul 2025

done

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

use only isDefault

LEAHI-TD-FIRMWARE-LDT-3126-1 03 Mar 2026

Replaced

LEAHI-APPLICATION-LDT-853-1 11 Jul 2025

RESOLVED

LEAHI-DD-FIRMWARE-LDT-3372-2 02 Mar 2026

its unsigned integer , no need to check -ve value

LEAHI-DD-FIRMWARE-LDT-3372-2 27 Feb 2026

Where is len used ?

LEAHI-TESTSUITES-LDT-3014-1 03 Mar 2026

please leave a comment above describng why the visible property is being left in

LEAHI-APPLICATION-LDT-2160-1 27 Aug 2025

updated

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

Remove for now.
Or any extra animation or UI cosmetics that are not a requirement.

LEAHI-APPLICATION-LDT-1636-1 15 Aug 2025

To be consistent with the other qml files, always move this onComplete to the end of the file.

RO-LDT-566-4 19 Aug 2025

Add blank line after declarations.

RO-LDT-566-4 19 Aug 2025

Align comment.

RO-LDT-1809-3 26 Aug 2025

Done

RO-LDT-1809-3 26 Aug 2025

Added comment line

RO-LDT-1809-3 26 Aug 2025

Removed multiple returns

RO-LDT-1809-3 26 Aug 2025

Added blank lines as needed

RO-LDT-1809-3 26 Aug 2025

Add @param for new param.

LEAHI-APPLICATION-LDT-2160-1 27 Aug 2025

updated

LEAHI-APPLICATION-LDT-2160-1 27 Aug 2025

updated