Let's review PRS req together. Seems like we have conflicting alarm properties in place that don't make sense to me. Let's figure out what behavior Systems team is looking for here and then decide what properties/persistence should be set.
1. Style, and preference to keep loop control at the top, not buried in the state function. 2. Keep stack size for the state function more predictable. 3. I was considering unwrapping the state machine, starting with a separate pause state, that held for priming to advance to the proper state
Ultimately the simplest change may be limited to just this ifndef. No practical reason to move the declaration in that case.
happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2 Ill reorganize the review naming shortly.
The reason is separation and keeping the logic of the Slider and its ON/OFF switch clear and non-confusing, and independent. Like right now that I had a wrong fix and I easily just changed the connection related to the fix I had not changed the Slider implementation itself.
Is there a specific reason to why we are opting to use a connection here instead of handling the signal in the component body? (ie: line 181 further down?)
