•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

Needs function header

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

levels.py

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

DG should be DD.

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

DD-LEAH-224-1 24 Feb 2025

Removed. Done.

DD-LEAH-230-1 27 Feb 2025

4184.0F and (F32)SEC_PER_MIN

UI-DEN-17157-1 25 Feb 2025

RESOLVED

LEAHI-DIALIN-LEAH-261-1 24 Feb 2025

Remove extra blank line.

TD-LEAH-838-1 20 Feb 2025

isAutoControlling?

RO-LEAH-273-1 04 Mar 2025

Add comment. Also, we've customarily kept mode abbreviation to 4 letters (i.e. GENP).

RO-LEAH-273-1 04 Mar 2025

Add blank line between banner and #define.

RO-LEAH-273-1 04 Mar 2025

Are these TBDs? You'll set actuators as appropriate for each state?

RO-LEAH-273-1 04 Mar 2025

What is the time unit per count (e.g. minute, second, milliseconds, etc.)?

RO-LDT-566-1 30 Jun 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-627-1 30 Jun 2025

Yes it was added intentionally per Seans requests

RO-LDT-566-1 30 Jun 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-1021-1 01 Jul 2025

Updated and added check

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

Please ask the FW team (Sean) if they would like this to be a column with labels, similar to the other messages. If that helps, we may still have room on the TD page, and we have separated the subsystem messages.

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

I understand.
No problem then.

RESOLVED

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

This must be removed.

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

Refactor this to BloodFlow to match the application message naming.

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1021-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 03 Jul 2025

RESOLVED

LEAHI-SW-LDT-627-1 30 Jun 2025

Not needed, please remove.
I had this in old versions, but it was unnecessary.

LEAHI-SW-LDT-627-1 03 Jul 2025

will take care of it later.

LEAHI-SW-LDT-627-1 03 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1021-1 03 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

These values do not match the PRS

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

Is this necessary?

UI-DEN-14517-1 10 Feb 2023

Only a suggestion:
It is a good idea to append the unit to the end of the variable name especially for time. It helps improve readability and clarity.

For instance, here, we have ms and the next one, _pendingInterval is in seconds. and I believe _pendingCounter is in minutes based on the .cpp file's comment.

_interval_ms
_pendingInterval_sec
_pendingCounter_min

HD-DEN-16446-2 19 Oct 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14646-1 27 Feb 2023

Remove "endif" at end of comment?

UI-DEN-14733-2 10 Feb 2023

Yes, assignments break bindings.

RESOLVED

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

HD-DEN-14459-1 15 Feb 2023

Unlikely that we would go from Liq/Liq to Air/Air, but if we did, we would no longer turn the air pump off with this code removed. Should we keep it?

HD-DEN-14459-1 15 Feb 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 06 Feb 2025

Fixed. Thanks!