•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

is this resolved?

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Barometer sensor CRC value.

RO-LEAH-273-1 04 Mar 2025

Need to add a column for RO_MODE_GENP too (not just a row).
The row shows which modes (columns) you can transition to from that mode associated with the row.
If it's allowed, put the new mode. If it's not allowed, put RO_MODE_NLEG.
The items on the diagonal (top left to bottom right) are always allowed since you're not changing the mode.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Refactor per f/w naming.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Not conductivity.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Refactor per f/w naming.

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

DG should be DD.

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

There is additional dialin command that needs to be supported for message ID: MSG_ID_DD_BC_SWITCH_ONLY_START_STOP_OVERRIDE_REQUEST.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Should heater param be a Heater_Names enum instead of an int? (comment applies to all override cmds in all classes)

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Specify DD throughout DD classes in function headers and console output text to make it clear we are talking about DD component. DD and RO share a lot of components so we want to be specific to remove ambiguity. e.g. ".. DD conductivity sensor data messages.".

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

pressure_sensors.py

TD-LEAH-838-1 21 Feb 2025

Yes. Done.

TD-LEAH-838-1 20 Feb 2025

I remember there was a change done in Denali to extend the timeout value. Do we need to adjust the timeout value for LEAHI?

TD-LEAH-838-1 20 Feb 2025

No Alarm, Add Event ID.

TD-LEAH-838-1 20 Feb 2025

3-way

TD-LEAH-838-1 20 Feb 2025

I guess air trap monitor function handles the timeout function and no need of handling time out here (TODO).

RO-LEAH-273-1 04 Mar 2025

The function name is not the same as the comment. Which one (to preprare or to transition)?

RO-LEAH-273-1 04 Mar 2025

Use genPermeateState variable here instead of enum.

RO-LEAH-273-1 04 Mar 2025

ModeGenPermeate.c.

RO-LEAH-273-1 04 Mar 2025

Remove blank line.

LEAHI-DIALIN-LEAH-261-1 24 Feb 2025

We should remove DG references throughout. If f/w doesn't call for some of these yet, lets just remove them for now.

RO-LEAH-273-1 04 Mar 2025

Why not default case?

LEAHI-DIALIN-LEAH-261-1 24 Feb 2025

function header?

RO-LDT-566-1 30 Jun 2025

Align ALL comments.

RO-LDT-566-1 30 Jun 2025

Why did we remove the code that deals with read/error counters if we're unsure?

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

align

HD-DEN-14273-1 09 Feb 2023

#define for 0

DD-LEAH-1971-1 28 Jan 2025

Done.

HD-DEN-14561-1 08 Feb 2023

Fixed.

HD-DEN-14561-1 08 Feb 2023

Fixed.

HD-DEN-14561-1 08 Feb 2023

Fixed.

HD-DEN-14561-1 08 Feb 2023

Fixed.

HD-DEN-14561-1 08 Feb 2023

Fixed.

HD-DEN-14561-1 08 Feb 2023

Fixed.

HD-DEN-14561-1 08 Feb 2023

Fixed.

HD-DEN-14561-1 08 Feb 2023

Fixed.

HD-DEN-14561-1 08 Feb 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14561-1 08 Feb 2023

getReservoirFillStatus is a function

HD-DEN-14561-1 08 Feb 2023

reservoirStatus

HD-DEN-14561-1 08 Feb 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14561-1 08 Feb 2023

reservoirStatus

HD-DEN-14561-1 08 Feb 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14561-1 08 Feb 2023

reservoirStatus

HD-DEN-14561-1 08 Feb 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14561-1 08 Feb 2023

reservoirStatus

HD-DEN-14561-1 08 Feb 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14561-1 08 Feb 2023

ReservoirStatus

HD-DEN-14561-1 08 Feb 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14561-1 08 Feb 2023

Should be reservoirStatus instead of reservoirFlags.