•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

remove drop shadow

LEAHI-APPLICATION-LDT-853-1 11 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

updated

LEAHI-APPLICATION-LDT-1209-1 15 Jul 2025

RESOLVED.

LEAHI-APPLICATION-LDT-1636-1 14 Aug 2025

this has been removed

LEAHI-APPLICATION-LDT-1636-1 14 Aug 2025

RESOLVED.

LEAHI-APPLICATION-LDT-1636-1 15 Aug 2025

updated

LEAHI-APPLICATION-LDT-1636-1 15 Aug 2025

RESOLVED

HD-DEN-16446-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14604-1 03 Feb 2023

Done.

DD-LEAH-1971-1 28 Jan 2025

Done.

DG-DEN-14604-1 03 Feb 2023

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-1971-1 28 Jan 2025

Should these only be defined if USE_PT_100 is defined?

DG-DEN-14604-1 03 Feb 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14604-1 03 Feb 2023

Done

LEAHI-TD-FIRMWARE-LDT-3126-1 26 Feb 2026

Why do we need this local variable when we have the static requestedBloodFlowRate_mL_min variable?

DG-DEN-14604-1 03 Feb 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14604-1 03 Feb 2023

Shouldn't this one stay "MIN"?

HD-DEN-14561-1 02 Feb 2023

This simplified equation works because we added up flow (mL/min) measurements for 1 minute. If we change displacement time, it falls apart (not generalized) which happens in second displacement below (now that transfer time was reduced to 30 sec).
Let's generalize this math to clarify it and make it work regardless of time.

Suggested approach:
-integrate volume above properly (don't just sum rates over time).
-Should be: fmdIntegratedVolume += ( getMeasuredDialInFlowRate() / (F32)( ( SEC_PER_MIN * MS_PER_SECOND ) / TASK_GENERAL_INTERVAL ) );
-Then we don't need to convert here at end of displacement - can just use fmdIntegratedVolume as is in verify state.

HD-DENBUG-290-1 29 Jan 2025

Do we not have a serial # type already defined somewhere? I don't like defining types locally within a function.

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

HD-DENBUG-290-1 29 Jan 2025

Done

HD-DENBUG-290-1 29 Jan 2025

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-290-1 29 Jan 2025

Not needed. Remove.

DD-LEAH-1971-1 28 Jan 2025

Should only be if PUMP_TEST defined?

LEAHI-DIALIN-LEAH-139-3 06 Feb 2025

Fixed. Thanks!

LEAHI-APPLICATION-LDT-627-1 30 Jun 2025

I forgot to adjust the application. H6 is correct for the rotor hall state

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

DG should be DD.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

FMP/FMD are DG names.

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

The piston pumps dont seem to have naming ID's in the FW. Do you have a doc i can reference?

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Not pressure. Filtered temperature.
Also, ask Vinay if this should be moved to temperature_sensors class.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Barometer sensor read counter value.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

DD levels broadcast interval override.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

DG should be DD.

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Added. Thanks!

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Message ID should be MSG_ID_DD_CONDUCTIVITY_SENSOR_TEMPERATURE_OVERRIDE_REQUEST

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Not balancing chamber. This is Gen Dialysate broadcast handler.

TD-LEAH-838-1 21 Feb 2025

Change has not happened yet in Denali. I will follow up with Dara after change is made.

TD-LEAH-838-1 21 Feb 2025

Done.

TD-LEAH-838-1 21 Feb 2025

Done.

TD-LEAH-838-1 20 Feb 2025

Please add in outputs: currentAirPumpMotorPowerLevel

TD-LEAH-838-1 20 Feb 2025

MotorState to MotorPowerLevel - across file.

RO-LDT-566-1 30 Jun 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

align ;

LEAHI-SW-LDT-627-1 01 Jul 2025

It is already being done the same way. the int() handles bool to integer conversion with no issues

LEAHI-SW-LDT-627-1 30 Jun 2025

Please align the "(" so the MIN, MAX, DEF get aligned.