•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-11750-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-11250-1 15 Feb 2022

Make a #define for bolus rate (40.0) and use here to initialize. Also initialize ovData field to the same #define.

HD-DEN-7395-1 11 Apr 2021

The states of the state machine should be private. This enum should be transferred to the .c file.

HD-DEN-7395-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-3421-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-3115-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-2650-1 06 May 2020

Insert blank line

DG-DEN-2650-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-COMMON-FIX-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DD-LEAH-1971-1 28 Jan 2025

Should be DIALYSATE flow rate. Should min/max rate be moved to dialysate pumps header file?

HD-DEN-14007-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-13903-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DD-LEAH-1971-1 28 Jan 2025

Done.

HD-DEN-11750-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-11750-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-17135-1 29 Jan 2025

Updated the trigger condition. This is a calibration and is checked in POST. The titles are POST.

UI-DEN-16288-1 19 Oct 2023

RESOLVED

UI-DEN-15896-1 19 Oct 2023

RESOLVED

DD-LEAH-1971-1 28 Jan 2025

It will be evaluated/updated when close loop pump testing happens.

UI-DEN-15279-5 19 Oct 2023

RESOLVED

UI-DEN-15279-1 19 Oct 2023

RESOLVED

DD-LEAH-1971-1 28 Jan 2025

Done.

UI-DEN-3149-1 19 Oct 2023

RESOLVED

UI-DEN-608-4 04 Dec 2019

Case need indentation

UI-DEN-12121-1 19 Oct 2023

RESOLVED

DD-LEAH-1971-1 28 Jan 2025

Done.

DIALIN-DEN-16419-1 19 Oct 2023

RESOLVED

DIALIN-DEN-14497-1 19 Oct 2023

RESOLVED

DIALIN-DEN-14497-1 19 Oct 2023

RESOLVED

UI-DEN-3605-4 19 Oct 2023

RESOLVED

DIALIN-BUG-S63-1 19 Oct 2023

RESOLVED

DIALIN-DEN-6593-1 08 Feb 2021

Note for reviewers: This doesn't show the latest change since this was fixed in the Sprint 36 branch. In the latest change resend is a parameter to the login cmd and is set to False by default.

DIALIN-ACK-1 19 Oct 2023

RESOLVED

DD-LEAH-1971-1 28 Jan 2025

Misspelled Dialysate.

DD-LEAH-1971-1 28 Jan 2025

Done.

DD-LEAH-1971-1 28 Jan 2025

Done.

DD-LEAH-1971-1 28 Jan 2025

Done

DD-LEAH-1971-1 28 Jan 2025

Yeap. will remove once we identify the UF pumps.

DD-LEAH-1971-1 27 Jan 2025

Group is inside #if/endif block so this end group marker should be above the #endif.

DD-LEAH-1971-1 28 Jan 2025

Is there not a generic helper function that does this? getF32OverrideValue() in TestSupport.c?

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

DD-LEAH-1971-1 28 Jan 2025

Do these heaters have a component code? I think they do. Why haven't these functions been refactored?

DD-LEAH-1971-1 28 Jan 2025

Obsolete?

DD-LEAH-1971-1 28 Jan 2025

Should we have D19..D26 here?

DD-LEAH-1971-1 29 Jan 2025

Add a blank line between function and end group marker.

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

I don't see the fix.

LEAHI-DIALIN-LEAH-139-3 06 Feb 2025

Fixed. Thanks!