•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-17220-1 07 Feb 2025

RESOLVED in CODE WALKTHROUGH.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Not heater duty cycle. DD Level sensor override.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Not heaters. Levels.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

It should be U32.

UI-DEN-17157-2 07 Feb 2025

change the ">>" (append) to ">" (overwrite).

DG-DEN-14604-1 03 Feb 2023

Missing break?

DG-DEN-14604-1 03 Feb 2023

Shouldn't this just be an if (not an else if)? If both are unhealthy, we should activate both alarms, right?

DG-DEN-14604-1 03 Feb 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14604-1 03 Feb 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14604-1 03 Feb 2023

Will this get picked up by doxygen? Do we want that? If not, maybe put this structure outside of the heat disinfect grouping.

DIALIN-DEN-14604-1 01 Feb 2023

It is very disappointing, after years of commenting to fix this error-prone index based, it is still being used and had not been fixed !!!

DD-LEAH-1971-1 28 Jan 2025

Done.

HD-DEN-16446-2 19 Oct 2023

In the If conditions, we check "uFVolume > colUFVol" conditions, that makes uFRate always positive and hence the condition for minimum check is not required.

DIALIN-DEN-16454-1 19 Oct 2023

UI will ignore the last two values, which is not using it.
FW can add extra fields, but for now if UI don't use it or does not have to use it will just ignore.

DD-LEAH-1971-1 28 Jan 2025

Bringing it top of header file, seems compiler not finding the #define and that makes code disabled even though its declared.

DD-LEAH-1971-1 28 Jan 2025

Done.

DD-LEAH-1971-1 28 Jan 2025

Done

DIALIN-DEN-16454-1 19 Oct 2023

All set. I have reverted it

DD-LEAH-1971-1 29 Jan 2025

I guess my point was about more than the comment. Can we test the default case in vectorcast? I think we can and so we should remove the #ifndef.

DD-LEAH-1971-1 28 Jan 2025

Can we remove this code now?

DD-LEAH-1971-1 28 Jan 2025

Should balancing chamber unit provide a function to set valves in one of the two states?

DD-LEAH-1971-1 28 Jan 2025

Recommend just calling updateTreatmentSettings() always and putting the flag check/reset code in the function.

LEAHI-SW-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-SW-LDT-627-1 01 Jul 2025

As we discussed, and I posted the comment on another one, please add these two regardless.

DG-DEN-17135-1 29 Jan 2025

The Trigger condition is little confusing. could you please reword it? Also In title, do you want to add " fault", if it is DG fault property?

DD-LEAH-1971-1 29 Jan 2025

Done.

RO-LDT-566-1 30 Jun 2025

fixed. thanks!

LEAHI-SW-LDT-627-1 30 Jun 2025

Found the code that we discussed for this conversion.
Please do the same here:
http://devapps.diality.us:8060/cru/#LEAHI-SW-LDT-627-1CFR-68014

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

align

RO-LDT-566-1 01 Jul 2025

align comments

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

fixed

LEAHI-SW-LDT-627-1 03 Jul 2025

fixed,
RESOLVED

DD-LDT-815-1 03 Jul 2025

Is this complete state needed? I don't see how we even get here.

LEAHI-APPLICATION-LDT-853-1 07 Jul 2025

removed qml enum

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

Regarding the conversation we had with Sean, the targetRate is the same as the CurrentRate.
RESOLVED

LEAHI-APPLICATION-LDT-627-1 03 Jul 2025

fixed!

LEAHI-SW-LDT-627-1 03 Jul 2025

fixed!

LEAHI-APPLICATION-LDT-1021-1 03 Jul 2025

updated and removed for now

LEAHI-APPLICATION-LDT-853-1 07 Jul 2025

created component for icons

LEAHI-APPLICATION-LDT-907-1 07 Jul 2025

Good point.
However, for debugging tools such as the Diagnostics screen and Logging, please Do Not translate.
Those are for our developers, and not only do they not have a translation requirement, but also, if we translate them to Japanese, then who will understand them?

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

updated the expanding arrow image to match resolution

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

This is used to dim the background for the lock popup.. Can be used later for all popups to give the effect and focus point for the popup

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 08 Jul 2025

Change the following, all to 80:

  • mainMenuHeight
  • topBarMenuHeight
  • notificationHeith
    And move the MainTreatment screen components to the center, ensuring that the top menu and alarm bar do not cover the treatment sections.
LEAHI-APPLICATION-LDT-853-1 08 Jul 2025

After addressing the following comment, this image will be removed and handled by the button properties.
http://devapps.diality.us:8060/cru/#LEAHI-APPLICATION-LDT-853-1CFR-69099

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

removed

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

REMOVED

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

remove alias

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

remove rounded and gradient