Alphabetical ordering.
Removed ethernet setup line.
Fixed. Thanks!
The normal value is too tight for the current hardware; it always fails this test, without the wider volume tolerance.
Done (By Darren)
Done (by Darren)
Done.
This works, even if the s.t. dry test is skipped.
This turns off the trimmer hearter, to smooth heater control (as before). The switch state (next up) actually makes the reservoir switch, the next state.
Done (By Darren).
RESOLVED in CODE WALKTHROUGH.
This is not going to work. Revisit. See code review for DEN-14749 for correct arrangement.
RESOLVED IN CODE WALKTHROUGH
Add pendingUFVolumeChange, pressTreatmentTimeSecs, pendingParamChangesTimer,
RESOLVED
Updated
Comment Alignment
Use SEC_PER_MIN instead of 60. Also comment says min, but really it is ms.
Alignment
This line should be in the else block.
Why is this variable an int? It should be U32.
RESOLVED IN CODE WALKTHROUGH.
These should not be commented out. Current FW builds have MSG_ID_PRESSURE_OCCLUSION_DATA = 0x9 with the following structure. /// Payload record structure for the pressure & occlusions data message. F32 arterialPressure; ///< Latest arterial pressure (mmHg) F32 venousPressure; ///< Latest venous pressure (mmHg) U32 bldPumpOcclusion; ///< Latest BP occlusion (no units) U32 presLimitState; ///< Current pressure limits state (enum-stabilization or stable) S32 artMinLimit; ///< Current arterial minimum pressure limit (mmHg) S32 artMaxLimit; ///< Current arterial maximum pressure limit (mmHg) S32 venMinLimit; ///< Current venous minimum pressure limit (mmHg) S32 venMaxLimit; ///< Current venous maximum pressure limit (mmHg) F32 arterialLongFilterPres; ///< Latest long filtered arterial pressure (mmHg) F32 venousLongFilterPres; ///< Latest long filtered venous pressure (mmHg) PRESSURE_OCCLUSION_DATA_T;
Consider putting this code in a static function.
Why is this commented out? Can we remove it?
I would change 105 to 9999 or something very high and then add any new s/w faults below these (i.e. 105..).
Moved it to the top.
This is sent only once
I don't see fix.
Wrong file name. Not treatment_delivery.py. I would actually prefer something like filtration_purification.py.
Done
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
