Comment Search

RESOLVED IN CODE WALKTHROUGH.

is this alignment correct? I see you align by . above (line 35-38) but I don't see examples of aligning by ( for function calls.

Fixed. Thanks!

RESOLVED in CODE WALKTHROUGH.

I laughed loud for a while
This is the spell checker dictionary.
Since my spell checker was complaining and it was bugging me, and I always look at it like there is a bug in that area, I add her name so spell checker won't highlight it anymore.
It is a comment I have about the decision we made to remind me why I have that line of code commented.

Why is her name in string table?

Any reason this alarm is commented out?

Fixed. Thanks!

Fair point.

Remove the blank line.

RESOLVED IN CODE WALKTHROUGH

RESOLVED

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

Good point,
I agree with the two intervals, it would be clarifying.
For the counter, though, it might not be always the case.
I will start doing it in my next task, since I would like to change all, to be consistent across the entire code base.

Done.

I think we wanted the alias and not the bool. I vaguely remember suggesting the change to alias. This could've been a revert change. I am not sure. I will change it back to alias

RESOLVED

Ok, sounds good.

RESOLVED

Please adjust the alignment(few #defines)

Missing two fields. Current DG FW has MSG_ID_DG_HEATERS_DATA = 0x2C as

/// Heaters data structure.
typedef struct

F32 mainPrimayHeaterDC; ///< Main primary heater DC
F32 smallPrimaryHeaterDC; ///< Small primary heater DC
F32 trimmerHeaterDC; ///< Trimmer heater DC
F32 primaryTargetTemp; ///< Primary heater target temperature
F32 trimmerTargetTemp; ///< Trimmer heater target temperature
U32 primaryHeaterState; ///< Primary heater state
U32 trimmerHeaterState; ///< Trimmer heater state
F32 primaryEfficiency; ///< Primary heater efficiency
F32 primaryCalcTargetTemp; ///< Primary heater calculated target temperature
F32 trimmerCalcCurrentTemp; ///< Trimmer heater calculated current temperature
U32 trimmerUseLastDC; ///< Trimmer heater use last duty cycle
F32 previsouFlow; ///< Trimmer heater previous flow L/min
U32 controlCounter; ///< Trimmer heater control count

HEATERS_DATA_T;

Why aren't we treating blood leak recovering alarm the same as creating dialysate alarm?

Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T*) necessary? Seems like &concPump->concentratePumps[ i ] is already that type.

my bad. Now its fixed! I'll probably change the whole RO directory to something like FP in a future update to stay in sync with the naming of the subsystems

Done.

Refactor to f/w naming.