•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-13598-2 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-13460-2 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-13460-2 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-12847-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-11250-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-11250-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-11098-1 23 Nov 2021

Done.

DG-DEN-7568-1 14 Apr 2021

When do you think we will have something for this? I thought I heard Blaine say he thought we could get RPM conversion close enough to re-implement check.

HD-DEN-7395-1 11 Apr 2021

I think it is a good practice to reset all the important variables that are defined as static in the .c file.

HD-DEN-6402-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-2379-1 20 May 2020

Seems like you could set this state in the exec switch statement instead of having a function do it.

HD-DEN-14561-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-11750-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-11750-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-11750-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

UI-DEN-15279-1 19 Oct 2023

RESOLVED

UI-DEN-12121-1 19 Oct 2023

RESOLVED

UI-DEN-3253-1 19 Oct 2023

RESOLVED

UI-DEN-608-4 04 Dec 2019

I would suggest to use a more descriptive Error string, like, Error: Cannot instantiate QCanBus

UI-DEN-608-4 19 Oct 2023

RESOLVED

UI-DEN-608-4 19 Oct 2023

RESOLVED

UI-DEN-608-4 19 Oct 2023

RESOLVED

UI-DEN-608-4 19 Oct 2023

RESOLVED

UI-DEN-608-4 04 Dec 2019

Case need indentation

UI-DEN-704-1 19 Oct 2023

RESOLVED

DIALIN-DEN-16419-1 19 Oct 2023

RESOLVED

UI-DEN-3605-4 06 Oct 2020

Please put a short description of your component and explain what it does and where it can be used.
Since it is a specific or compound component and is not a general component like a just a Slider or Progressbar, it helps to understand the use case of the component.

UI-DEN-3605-4 19 Oct 2023

RESOLVED

DIALIN-DEN-12358-1 19 Oct 2023

RESOLVED

DIALIN-DEN-12358-1 11 May 2022

I'm ok with this either way. Ternary should not be viewed as confusing, but agree it is unnecessary.

DIALIN-DEN-11980-1 17 Feb 2022
DIALIN-BUG-S63-1 02 Feb 2022

Totally in favor of the workaround.

DIALIN-BUG-S63-1 02 Feb 2022

Overall the use of this file is a bit funny. If this is ran within a Squish test, maybe we should rename/move the file (Ex: system_env_BAT.py) to be more coherent as it currently implies that it is unit testing something in this folder when it is testing the ENV and CAN.

DIALIN-DEN-8055-1 19 Oct 2023

RESOLVED

DIALIN-DEN-6593-1 19 Oct 2023

RESOLVED

HD-DEN-16446-2 19 Oct 2023

The result will be an unsigned integer

DIALIN-DEN-16454-1 19 Oct 2023

Michael Garthwaite
Ui code is frozen and we cannot change the UI code, so matched with what currently exists in UI.
The attempt was to fix the integration tests, and we did not go over all the messages API to fix them.
We can have it done later when have more time.

DIALIN-DEN-16454-1 19 Oct 2023

good point.
Vy will fix it.

DIALIN-DEN-16454-1 19 Oct 2023

Done.

DIALIN-DEN-16454-1 19 Oct 2023

Resolved.

DIALIN-DEN-16454-1 19 Oct 2023

Resolved.

DG-DEN-14604-1 03 Feb 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14604-1 02 Feb 2023

Alignment. Do we even need this. Will get reset on transition back to heat disinfect.

DG-DEN-14604-1 03 Feb 2023

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-1971-1 28 Jan 2025

Add TODO

DIALIN-DEN-2652-1 20 May 2020

Delete

HD-DENBUG-96-1 11 Oct 2023

Add setUFRate to header.

DG-DEN-12974-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DD-LEAH-1971-1 28 Jan 2025

D5?

DG-DEN-11928-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH