•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-13598-2 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-14561-1 31 Jan 2023

What does flush complete have to do with draining here?

HD-DEN-14561-1 31 Jan 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14561-1 31 Jan 2023

Done.

HD-DEN-14561-1 31 Jan 2023

We are asking DG to set the currently active reservoir as the active reservoir? So no change?

HD-DEN-14561-1 01 Feb 2023

Alignment

HD-DEN-14561-1 31 Jan 2023

Done.

HD-DEN-14549-1 31 Jan 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14549-1 31 Jan 2023

Add alarmActionResumeReceived.

HD-DEN-14561-1 31 Jan 2023

Done. We will want to verify that we don't disable all of the resume fill calls.

UI-DEN-14609-1 01 Feb 2023

Please remove this.
We are not required to set up ethernet.
It is only used in the run.sh for development and service.and we may remove it

HD-DEN-14561-1 01 Feb 2023

Misalignment of terminology. I treated a reservoir "flush" as a fill/drain cycle, ending with the reservoir empty. "flushComplete" had been set accordingly. Test removed.

HD-DEN-14561-1 31 Jan 2023

We don't want to signal here if we don't have an air pump.

HD-DEN-14561-1 02 Feb 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14604-1 03 Feb 2023

These values are temporary and only when we build a debug code. So I prefer not to have a #define for them.

DG-DEN-14604-1 03 Feb 2023

This include is no longer needed.

DG-DEN-14604-1 03 Feb 2023

Done

DG-DEN-14604-1 03 Feb 2023

Done.

DG-DEN-14604-1 02 Feb 2023

Declarations at top of scope.

UI-DEN-14609-1 01 Feb 2023

As a general comment, you don't need to worry about the copyrights, and it will be updated/overwritten by our Bamboo server scripts with the last user and date and time.

HD-DEN-14561-1 31 Jan 2023

Add spaces around (). And literal should go to right unless using == operator.

UI-DEN-14609-1 01 Feb 2023

please log your steps results in POSTOUT and POSTERR like what is done (deleted line) on line 124.

DG-DEN-14604-1 03 Feb 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14604-1 03 Feb 2023

Done

HD-DEN-16446-1 03 Oct 2023

Done

DG-DEN-14604-1 03 Feb 2023

Done

LEAHI-TD-FIRMWARE-LDT-3126-1 27 Feb 2026

Removed

DG-DEN-14604-1 03 Feb 2023

The enum comments are now non-doxygen style, but the enum is still in the group. Move it below the /*@}/ to get it out of HeatersState group.

HD-DEN-13834-1 18 Oct 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14604-1 03 Feb 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14604-1 03 Feb 2023

RESOLVED IN CODE WALKTHROUGH

DD-LEAH-1971-1 28 Jan 2025

Treatment is misspelled.

DG-DEN-14604-1 03 Feb 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16372-1 04 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DENBUG-84-1 04 Oct 2023

Thanks. Was not sure about that but wanted to cover it if bolus extended to treatment mode. Removed.

LEAHI-TESTSUITES-LDT-1218-1 15 Oct 2025

Aligned all items.

HD-DENBUG-84-1 05 Oct 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16446-1 06 Oct 2023

Resolved in code review.

DG-DEN-16475-1 09 Oct 2023

Fixed. Thanks!

DD-LEAH-1971-1 28 Jan 2025

Treatment is misspelled.

HD-DENBUG-96-1 11 Oct 2023

Fixed.

HD-DENBUG-96-1 11 Oct 2023

RESOLVED IN CODE WALKTHROUGH

LEAHI-TD-FIRMWARE-LDT-3126-1 27 Feb 2026

Updated

DG-DEN-13598-2 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-13598-2 20 Sep 2022

Already removed marge markers.

DD-LEAH-1971-1 28 Jan 2025

Should this be a build switch in DDCommon.h?

DG-DEN-16446-2 17 Oct 2023

RESOLVED IN CODE WALKTHROUGH.

DIALIN-DIAL-289-1 17 Oct 2023

It was in the incorrect position in previous commit. Fixed. Thanks!

DIALIN-DIAL-289-1 17 Oct 2023

Add + top.

DIALIN-DIAL-289-1 17 Oct 2023

RESOLVED.