•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

dialysate_pumps_sync? also the comments underneath to remove concentrate pumps.

DD-LEAH-224-1 24 Feb 2025

Call transition function here instead.

DD-LEAH-224-1 24 Feb 2025

Done.

UI-DEN-17157-1 25 Feb 2025

Done

HD-DEN-14328-1 19 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14561-1 19 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-1971-1 27 Jan 2025

Add TODO comment.

HD-DEN-14561-1 19 Jan 2023

So R2 fill was 1100 and you say it ended up at 500. Would be 800 if keep same at 1100. If we change to 600, would end around 300 as you say - I think that's right.

HD-DEN-14011-1 20 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14561-1 20 Jan 2023

Updated to 600.

HD-DEN-14011-1 20 Jan 2023

Fixed. Only checking if BP is running when are in treatment mode.

HD-DEN-14011-1 20 Jan 2023

Fixed. Thanks!

HD-DEN-14011-1 20 Jan 2023

Fixed. Created handleDrySelfTestStartState() that counts settle time once the latch is determined closed.

HD-DEN-14011-1 20 Jan 2023

Should this be moved into "if" body? Doesn't appear to need setting until we resume.

HD-DEN-14011-1 20 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14011-1 20 Jan 2023

Should this 10 seconds only start once latch is locked?

HD-DEN-14011-1 20 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14011-1 20 Jan 2023

transition and resume part of stopped state should set pump track required so we don't have to keep setting it here every 50 ms.

HD-DEN-14011-1 20 Jan 2023

Not sure exception for treatment stop state still makes sense. We can be running BP in that state now depending on alarm. Should still alarm on occlusion.

HD-DEN-14011-1 20 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14561-1 20 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14561-1 20 Jan 2023

Done.

HD-DEN-14549-1 25 Jan 2023

Add salineBolusStartRequested to header

HD-DEN-14011-1 20 Jan 2023

Do we need an else where we reset 10 second start time (if latch opened)?

HD-DEN-14011-1 20 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14011-1 20 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14561-1 20 Jan 2023

Done.

HD-DEN-14561-1 20 Jan 2023

Done.

HD-DEN-14011-1 20 Jan 2023

Fixed. Thanks!

HD-DEN-14011-1 20 Jan 2023

Fixed. Thanks!

HD-DEN-14011-1 20 Jan 2023

Fixed. Thanks!

HD-DEN-14011-1 20 Jan 2023

Fixed. Thanks!

HD-DEN-14011-1 20 Jan 2023

If going back to start state, set pump track closed required, but not door closed. If skipping dry self-tests, set both to be required closed.

Also, this s/w config looks like it's setup wrong. For release build, we want to go back to start state.

HD-DEN-14011-1 20 Jan 2023

Should set door and pump track required here before we move on to next state.

HD-DEN-14011-1 20 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14011-1 20 Jan 2023

Should set pump track closed required, but not door here.

HD-DEN-14011-1 20 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14557-1 22 Jan 2023

Done

DG-DEN-14607-1 21 Jan 2023

Why is there an exception for overrides? Override is gauge, right? So we should always add baro to get absolute here, right?

HD-DEN-14557-1 22 Jan 2023

Should be or not and.

HD-DEN-14557-1 22 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14549-1 22 Jan 2023

Comments line up but the values don't?

DG-DEN-14607-1 23 Jan 2023

I removed the override.

DG-DEN-14607-1 23 Jan 2023

Done

DG-DEN-14607-1 23 Jan 2023

They have been aligned.

DG-DEN-14607-1 21 Jan 2023

Remove blank line.

DG-DEN-14607-1 23 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14607-1 23 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14607-1 23 Jan 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14607-1 22 Jan 2023

AlarmDefs changes need to be reconciled with the DG SRS