•  

Comment Results

Review Name Created Custom Fields Content
DD-LEAH-1971-1 28 Jan 2025

Done.

HD-DEN-15196-3 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-15274-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DD-LEAH-1971-1 28 Jan 2025

Done.

HD-DEN-14344-5 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-13801-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DD-LEAH-1971-1 28 Jan 2025

Done.

HD-DEN-13460-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-11750-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DD-LEAH-1971-1 28 Jan 2025

Done.

HD-DEN-11750-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

UI-DEN-608-4 19 Oct 2023

RESOLVED

DD-LEAH-1971-1 28 Jan 2025

Done.

UI-DEN-608-4 19 Oct 2023

RESOLVED

UI-DEN-608-4 19 Oct 2023

RESOLVED

DD-LEAH-1971-1 28 Jan 2025

Done.

UI-DEN-608-4 19 Oct 2023

RESOLVED

DIALIN-DEN-11980-1 19 Oct 2023

RESOLVED

DD-LEAH-1971-1 28 Jan 2025

Done.

DIALIN-UI-S63-1 19 Oct 2023

RESOLVED

DD-LEAH-1971-1 27 Jan 2025

Change 0 to 0.0F.

DD-LEAH-1971-1 28 Jan 2025

Comment no longer necessary.

DIALIN-DEN-16454-1 19 Oct 2023

this message structure is in Release FW. What is the UI going to with the incorrect message size?

DD-LEAH-1971-1 28 Jan 2025

Does floater have a component code? Or is this for all floaters?

DD-LEAH-1971-1 28 Jan 2025

BLD = D42.

DD-LEAH-1971-1 28 Jan 2025

Are these obsolete now?

DD-LEAH-1971-1 28 Jan 2025

This is problematic. New msg IDs beyond this point in list will have 2 possible ID numbers. I think these need to be at the end of the normal message section of the list and given a very high ID number (e.g. 0x7000) so there is no chance of conflicting with other message IDs.

DG-DEN-17135-1 29 Jan 2025

Removed the typecast.

DG-DEN-17135-1 29 Jan 2025

RESOLVED in CODE WALKTHROUGH.

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 06 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 29 Jan 2025

".. the balancing chamber switch ...".

LEAHI-DIALIN-LEAH-139-3 29 Jan 2025

Refactor per f/w changes.

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Function name should change as well.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Does this belong in this class? Should be in temperature_sensors? Or is this a target temperature from TD? Work with Vinay to sort out.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

I can see that the override cmd function is named per the override message it sends (from f/w code), but the name doesn't seem to match what it does exactly. This is not an on/off or start/stop cmd. It is a set piston pump target flow rate command.
Work with Vinay and consider renaming here and in f/w.

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Refactor per f/w naming.

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Refactor per f/w naming.

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Maybe add the word "target" in function name and description to clarify for Dialin users.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Not heaters. DD Levels.

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!