•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

Please take a look at the leahi-sw.config repo.
git@bitbucket.org:diality-cloud/leahi-sw.config.git
All are updated and defined there per PRS.

LEAHI-APPLICATION-LDT-1021-1 01 Jul 2025

Not necessary to trim them all.
Just leave it to the script, this is informational.

RO-LDT-566-1 30 Jun 2025

fixed. thanks!

RO-LDT-566-1 30 Jun 2025

fixed. thanks!

RO-LDT-566-1 30 Jun 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

fixed

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

I got these directly from the TD code. the leahi message list is not up to date

LEAHI-APPLICATION-LDT-1021-1 01 Jul 2025

removed

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

align

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

incorrect assignment

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

Is the current rate the same as the target rate?
I think the target should be a fixed value that has not been reached, but the current rate is rising toward the target.

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1021-1 01 Jul 2025

Please also fix the "Disconnecting from WiFi."

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

unsigned.

DG-DEN-16446-1 28 Sep 2023

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

DD-LEAH-1971-1 27 Jan 2025

Add TODO comment.

DD-LEAH-1971-1 28 Jan 2025

CD1/CD2/CD3/CD4 should be refactored?

DD-LEAH-1971-1 28 Jan 2025

Done.

HD-DEN-7395-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DD-LEAH-1971-1 28 Jan 2025

Done.

HD-DEN-14561-1 19 Jan 2023

Updated for only reservoir 2 fill state.

DG-DEN-6890-1 09 Mar 2021

If no params, just remove this line from header.

DD-LEAH-1971-1 28 Jan 2025

Done.

DG-DEN-16446-1 29 Sep 2023

RESOLVED in CODE WALKTHROUGH. (with nausea)

DD-LEAH-1971-1 28 Jan 2025

Done.

DG-DEN-16446-1 29 Sep 2023

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

DG-DEN-16446-1 29 Sep 2023

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

HD-DEN-14328-1 19 Jan 2023

Fixed. Thanks!

HD-DEN-14328-1 19 Jan 2023

Put this (and blank line after) at top of function.

HD-DEN-16457-1 01 Oct 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14561-1 19 Jan 2023

This should probably be 600 since we'll only be transferring 300 to R1 in wet self-tests.

HD-DEN-14561-1 19 Jan 2023

Alignment

HD-DEN-14561-1 19 Jan 2023

We should initialize these with a loop iterating through each reservoir (in case a reservoir is added/removed at some point).

HD-DEN-14561-1 19 Jan 2023

Remove extra blank line.

DD-LEAH-1971-1 28 Jan 2025

Done.

HD-STT-3088-1 02 Oct 2023

Done.

DD-LEAH-1971-1 28 Jan 2025

Done.

DIALIN-DEN-16428-1 05 Oct 2023

RESOLVED.

DD-LEAH-1971-1 27 Jan 2025

Remove extra blank line.

HD-DENBUG-290-1 29 Jan 2025

This has been deferred for release 21.

HD-DENBUG-290-1 29 Jan 2025

RESOLVED in CODE WALKTHROUGH.

DIALIN-DIAL-289-1 17 Oct 2023

Fixed. New fields can be user inputted but will also default to 0. Thanks!

LEAHI-DIALIN-LEAH-139-3 29 Jan 2025

Refactor names.

DG-DEN-6200-1 14 Jan 2021

errorOccurredStartTime is confusing name considering how it's being used.

DIALIN-DIAL-289-1 17 Oct 2023

RESOLVED

DIALIN-DIAL-289-1 15 Oct 2023

Out of sync w/ HD f/w, which is expecting larger payload. Additional 3 fields can be zeroes, but payload size must be increased to 32 (x20) so HD will accept it.

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

align ;}

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

align: 01 instead of 1