•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-14549-1 18 Jan 2023

Good catch. Updated Voltages.c to behave same as Battery.c (trigger the correction alarm depending on whether in a treatment mode).

DD-LEAH-1971-1 27 Jan 2025

Add a TODO comment to reactivate this code.

HD-DEN-16442-1 20 Sep 2023

I think this should be a constant array of floats with NUM_OF_ACID_CONC_TYPES elements and initialize here with 1.0, 2.0, 3.0.

HD-DEN-14549-1 18 Jan 2023

I don't think I have this bug fix in my branch. Needs to be addressed in a more recent branch.

HD-DEN-14549-1 18 Jan 2023

RESOLVED IN CODE WALKTHROUGH

LEAHI-APPLICATION-LDT-1021-1 29 Jun 2025

RESOLVED

HD-DEN-14549-1 18 Jan 2023

Treatment mode check is not done in Voltages.c, so ALARM_ID_HD_AC_POWER_LOST will be set there in addition to ALARM_ID_HD_AC_POWER_LOST_IN_TREATMENT here. Is this the expected behavior?

HD-DEN-14549-1 18 Jan 2023

Yes, may need to be done when merging to Staging. Is this flag used independently anywhere? Or planned to be?

DG-DEN-13946-1 18 Jan 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14549-1 18 Jan 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14549-1 18 Jan 2023

This check for _IN_TREATMENT may need to be added to Valves.c ALARM_ID_HD_AC_POWER_LOST check from recent bug fix. Both look to be checked in every case. Is this flag used independently anywhere?

HD-DEN-14549-1 18 Jan 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14549-1 17 Jan 2023

Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both.

DG-DEN-14559-1 18 Jan 2023

Done

DG-DEN-14559-1 18 Jan 2023

Done.

DG-DEN-14559-1 18 Jan 2023

Done

DG-DEN-14559-1 18 Jan 2023

No, at this point we are done with the variable.

DG-DEN-14559-1 18 Jan 2023

That is true. I tested these functions and they reset only the minimum (necessary) variables.

DG-DEN-14559-1 18 Jan 2023

This alarm is still available.

DG-DEN-14559-1 18 Jan 2023

No, this code has been removed.

DG-DEN-14559-1 18 Jan 2023

Done

DG-DEN-14559-1 18 Jan 2023

Done.

DG-DEN-14559-1 18 Jan 2023

Done

DG-DEN-14559-1 18 Jan 2023

Done

DG-DEN-14559-1 18 Jan 2023

Done.

DG-DEN-14559-1 18 Jan 2023

Done

DG-DEN-14559-1 18 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14559-1 18 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14559-1 18 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14559-1 17 Jan 2023

Need to be careful with these.
These functions are currently resetting the POST functions to start at beginning, but also need to reset ANY variables that the POST functions use/set (not override variables though).
Also, since we are not re-initializing everything like a true reset does, we need to make sure that these modules are setup to restart or resume (whichever is more appropriate for the module) after POST completes if the module is in any way interrupted/deferred by POST or competing with POST for a resource/driver (e.g. RTC or NV-Data).

DG-DEN-14559-1 18 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14559-1 18 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14559-1 18 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14559-1 18 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14559-1 18 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14559-1 18 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14559-1 18 Jan 2023

Why does enum say otherwise (prime saline dialyzer time out)?

DG-DEN-14559-1 18 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14559-1 18 Jan 2023

Alignment

DG-DEN-14559-1 18 Jan 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14559-1 18 Jan 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14559-1 18 Jan 2023

Done

DG-DEN-14559-1 18 Jan 2023

Done

DG-DEN-14559-1 18 Jan 2023

Done

DG-DEN-14559-1 19 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14559-1 18 Jan 2023

Alignment

DG-DEN-14559-1 19 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14559-1 18 Jan 2023

Alignment

DG-DEN-14559-1 19 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14559-1 19 Jan 2023

RESOLVED in CODE WALKTHROUGH.