•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Do you disagree with name change?

LEAHI-DIALIN-LEAH-136-3 06 Feb 2025

my bad. Now its fixed!

LEAHI-DIALIN-LEAH-139-3 29 Jan 2025

Refactor names per f/w changes.

UI-DEN-17157-1 25 Feb 2025

Done

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

I guess Eliza mentioned not to move it to temperature class/module unless otherwise it has own Part ID in flow path (like conductivity sensor temperature).

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Refactor per f/w naming.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Should be MSG_ID_DD_GEN_DIALYSATE_MODE_DATA.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Should there be an enum for the list of piston pump names?

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

File name is not plural like it is here. I think it should be, but either way, they should match.

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

change filename to 'dilaysate_pump'.

TD-LEAH-838-1 20 Feb 2025

please add description/details along with the Message ID

UI-DEN-17157-1 25 Feb 2025

Please put a comment here for next developer to avoid confusion:
/*
It is only for the dry-demo due to its independent flow.
Otherwise, won't needed in the normal designed user-flow.
*/

UI-DEN-17157-1 25 Feb 2025

Done

RO-LEAH-273-1 05 Mar 2025

Based on previous comment regarding pause state, Im not entire sure if i need it just yet. may remove or flesh out implementation

RO-LEAH-273-1 05 Mar 2025

If standby idle isn't doing anything, why not stay in idle during alarms?

RO-LEAH-273-1 04 Mar 2025

Shouldn't state get assigned to low or high state from here? If not, how do we get out of start state.
Also, do we even need a start state?

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

BN: RESOLVED

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

Any reason why this is implemented while there is no application-related message defined?

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

fixed!

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

fixed!

LEAHI-SW-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

Update the decimal(17)

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

The list does not match the Leahi Messages List parameters.
Any specific reason?

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

I think you removed the BloodPump and replaced it with BloodFlow in the application.
This should match the application message naming?

LEAHI-APPLICATION-LDT-1021-1 29 Jun 2025

Disconnecting from Wifi.
Additionally, please use WiFi to maintain consistency with the message strings.

LEAHI-APPLICATION-LDT-1021-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

Is there a specific reason for 0.600 being the default value?
If this is coming from Denali, we should review the value; otherwise, it needs to be discussed, reviewed, and a comment added to clarify.

LEAHI-APPLICATION-LDT-2160-1 08 Sep 2025

fixed

LEAHI-APPLICATION-LDT-2160-1 08 Sep 2025

added prvious behavior

LEAHI-DD-FIRMWARE-LDT-2198-1 15 Sep 2025

renamed to readFloaterLevelstatus()

DG-DEN-15973-2 14 Sep 2023

Dara, I mean inline comments for the magic numbers. Explain what 40 and 32 mean and why you're using those values.

LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED

DG-DEN-15973-2 14 Sep 2023

Done

DG-DEN-15973-2 14 Sep 2023

Magic numbers?

DG-DEN-15973-2 14 Sep 2023

RESOLVED in CODE WALKTHROUGH.

CS-BUILD-0-2-4-1 16 Jan 2023

Radu:
"The Team is in the progress of updating and refactoring. and classes and functions may need to change to better be able to test. Therefore all the missing documentation will be addressed in upcoming build"

DIALIN-DEN-16419-1 14 Sep 2023

small typo

DD-LEAH-1971-1 28 Jan 2025

Done.

HD-DEN-14549-1 17 Jan 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14549-1 12 Jan 2023

Add dgServiceAndUsageData to header.

DD-LEAH-1971-1 27 Jan 2025

Can we remove this line of code?

DD-LEAH-1971-1 28 Jan 2025

When would this request be made?

HD-DEN-16442-1 18 Sep 2023

General issue - please consider appropriateness of using this calculation when calling this function.

HD-DEN-16442-1 19 Sep 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16442-1 19 Sep 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16442-1 19 Sep 2023

I don't think we want to use recorded volume (would want inactive reservoir if we did). I think we want to use your function here that calculates the target fill volume.