•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-627-1 03 Jul 2025

discussed that config values in repo dont match PRS (252/253/269). Leaving as is.

LEAHI-APPLICATION-LDT-907-1 07 Jul 2025

Same comment for debugging tools.
http://devapps.diality.us:8060/cru/LEAHI-APPLICATION-LDT-907-1#c22752

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

RESOLVED.

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

keep these

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

remove

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

removed logic

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

removed

DIALIN-DEN-14497-1 05 Jan 2023

Gets the most recent embedded mode command response for a given command.

DG-DEN-14497-1 11 Jan 2023

RESOLVED IN CODEWALKTHROUGH.

UI-DEN-16288-1 31 Aug 2023

RESOLVED

HD-DEN-14497-12 11 Jan 2023

Done

HD-STT-2824-1 31 Aug 2023

You mean we need extra blank lines?

HD-DEN-14310-1 12 Jan 2023

Agree. Done.

UI-DEN-16335-4 05 Sep 2023

just wondering if a

chmod -R g-w,g+r,o-rwx /var/configurations/CloudSync/*/*

would work?

DG-DEN-13946-1 13 Jan 2023

Updated comment

HD-DEN-14310-1 12 Jan 2023

Should we have an else for this if where we zero the positionOUtOfRangeCounter?

HD-DEN-14310-1 12 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14549-1 13 Jan 2023

It is in the header under Outputs.

DG-DEN-15973-1 08 Sep 2023

Corrected

DG-DEN-16314-1 08 Sep 2023

Add blank line between this code and switch below.

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"We are currently modifying functions and methods, to make them easier for UnitTesting and it is changing. If you don't mind we will address all the old and new functions when we are done with our modifications and code cleanup to add the the function documents"

CS-BUILD-0-2-4-1 13 Jan 2023

RESOLVED.

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"Added the comment"

DG-DEN-13946-1 13 Jan 2023

Only used if the load cell is out of range.

DG-DEN-13946-1 13 Jan 2023

Only used if Temperature is in alarm.

DG-DEN-13946-1 13 Jan 2023

Corrected.

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"Added the comment"

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"Regarding the Diality Coding Standard, we have to comply with the PIP257, which doesn't enforce to use "@" or ":", regardless if it is Diality's preference, let us do it in the next build."

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"Regarding the Diality Coding Standard, we have to comply with the PIP257, which doesn't enforce to use "@" or ":", regardless if it is Diality's preference, let us do it in the next build."

CS-BUILD-0-2-4-1 13 Jan 2023

RESOLVED

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"The ui_cs means the direction of the communication, and when the direction doesn't matter w only put the entity names as uics. but if it clarifies better will remove the uics to io "

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:

  • "It will be used for the device registration and validation on the CloudSystem"
    Behrouz:
  • "This file is part of the code repo, and those were not part of an example, those were actual hardcoded information which later had to be set by MFG on the device and a sorry has been created for that."
CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"The parameters are now cleaned up and only the constant parameters are kept."
"UI needs to fill in some parameters later and CS will fill in/modify some others, regarding the QA or INT server being used and the device information"

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"The port is now changed to 5001"

CS-BUILD-0-2-4-1 13 Jan 2023

RESOLVED

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"fixed."

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"fixed."

CS-BUILD-0-2-4-1 13 Jan 2023

RESOLVED

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:

  • "fixed."
  • "The 30000 and 31000 are a workaround for a bug which we are currently working on and will be removed when fixed."
CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"Fixed"

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"fixed"

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"fixed."

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"Fixed"

CS-BUILD-0-2-4-1 13 Jan 2023

RESOLVED

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"Fixed"

CS-BUILD-0-2-4-1 13 Jan 2023

REOLVED

CS-BUILD-0-2-4-1 13 Jan 2023

Radu:
"Fixed"