•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

UI-DEN-16288-1 31 Aug 2023

thank you,
fixed.

HD-STT-2824-1 01 Sep 2023

No because we leave a blank line in between the declaration of a variable and the other lines.

DG-DEN-15973-1 01 Sep 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15973-1 01 Sep 2023

Removed blank line

UI-DEN-16335-1 05 Sep 2023

The shorter constructor is setting the local* values, I am saving the device name and address. Also, the error member variable is defaulted to 0 in the .h file.

UI-DEN-16335-1 05 Sep 2023

Done.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

I agree with this comment, to make the code fit in a shorter vertical area.
Please use the Bjarne Stroustrup everywhere and be consistent:

if () {
}
else {
}
HD-DEN-15792-1 07 Sep 2023

Done.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

Change to match above beginning { style.

DG-DEN-16314-1 08 Sep 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15973-1 08 Sep 2023

Keep declarations at top of scope. Just have assignments down here.

UI-DEN-16335-5 06 Sep 2023

update the length check of the message in MessageGlobals.h

const QHash<Gui::GuiActionType ,quint8> payloadLen {
.
.
{Gui::GuiActionType::ID_DialysateOutletFlow                     ,  10 * 4       }, //10 parameters each 4bytes
.
.
}
UI-DEN-16335-5 11 Sep 2023

RESOLVED

DIALIN-DEN-14497-1 11 Jan 2023

what is Z?

LEAHI-TD-FIRMWARE-LDT-1903-8 13 Feb 2026

Why not for release?

DD-LEAH-1971-1 28 Jan 2025

Same as above.

DD-LEAH-1971-1 28 Jan 2025

Done.

DD-LEAH-1971-1 27 Jan 2025

Change 1 to 1.0F to make clear we are defining a floating point value (not integer).

DD-LEAH-1971-1 27 Jan 2025

Add TODO comment.

DD-LEAH-1971-1 28 Jan 2025

Are these bits TBD or reserved?

LEAHI-APPLICATION-LDT-1596-1 13 Aug 2025

same as below

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

Instead of generic function, recommend adding a specific function something similar to "getACSwitchStatus' or 'getLeaskSensorStatus' and return the values ( ex: leak sensor Enum states?). Do we need to add the application code as well now, say if leak is found, trigger an alarm?

LEAHI-TESTSUITES-LDT-2741-1 13 Feb 2026
  • Isn't it better to name it like "findAllChildrenById"? Children instead of Objects?
  • And why do we add the parent, too?
    • That could be because you are using a recursive function, and I am not sure that is necessary.
  • Any object in QML has "id", do we need to check that, since it is not like the "objectName"
  • How could all id of the children be the same since there is no RegEx here?
DD-LEAH-1971-1 29 Jan 2025

Done

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Not pressure and occlusion data. Just RO pressure data.

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Remove "measured". Say "... pressure data broadcast ...".

LEAHI-DIALIN-LEAH-139-3 29 Jan 2025

".. concentrate pump park fault .."

LEAHI-DIALIN-LEAH-139-3 29 Jan 2025

" - for concentrate pump: "

LEAHI-APPLICATION-LDT-1596-1 13 Aug 2025

RESOLVED.

RO-LDT-566-1 27 Jun 2025

Remove extra blank line.

RO-LDT-566-1 27 Jun 2025

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-3126-1 26 Feb 2026

Same comment as other message handling function. Use correct payload type. See signalPauseResumeUF() function for example of how to respond to a UI request.

LEAHI-APPLICATION-LDT-2160-1 08 Sep 2025

updated

LEAHI-APPLICATION-LDT-2160-1 08 Sep 2025

added this back in

LEAHI-DD-FIRMWARE-LDT-3372-2 27 Feb 2026

Need mathematical formula as documentation and need to explain each term

LEAHI-APPLICATION-LDT-2160-1 08 Sep 2025

fixed

LEAHI-TD-FIRMWARE-LDT-1903-8 27 Feb 2026

pushed new code

LEAHI-TD-FIRMWARE-LDT-3126-1 27 Feb 2026

Removed

LEAHI-TD-FIRMWARE-LDT-3126-1 27 Feb 2026

Updated

LEAHI-TD-FIRMWARE-LDT-3126-1 26 Feb 2026

Let's add a TODO comment so we don't forget to uncomment this when syringe pump is implemented.

LEAHI-DD-FIRMWARE-LDT-3352-1 25 Feb 2026

mis aligned ?

LEAHI-TESTSUITES-LDT-2741-1 13 Feb 2026

if it is not in the if block add an empty line.

LEAHI-TESTSUITES-LDT-2741-1 13 Feb 2026

should this file be removed?

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Add TODO comment.

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Add blank line before function header.

DIALIN-DEN-14497-1 11 Jan 2023

RESOLVED.

UI-DEN-16288-1 31 Aug 2023

fixed

HD-DEN-16442-1 19 Sep 2023

Yes. The other alarms are handled in different drivers or modes. The above alarms are here to make sure HD sends the fill command after the bottles have been replaced.

DD-LEAH-1971-1 28 Jan 2025

When would we get this request? Should it be handled by balancing chamber unit directly?