Comment Search

Not arterial pressure.

RESOLVED

setROPumpTargetPressure doesnt have this check for 0. Is it something that we would need across all 3 set functions or not needed at all? Do we care that ovInitData is zero before assigning it to data if are overriding?

fixed. thanks

RESOLVED in CODE WALKTHROUGH.

updated to use #FEFEFE

RESOLVED

In bluetoothInterface.cpp, there's a set of macros towards the top. NOTIFY_DEVICE_CONNECT and NOTIFY_DEVICE_DISCONNECT

I made the changes based on the call we had.

Please make it twice thinner (10 => 5)

make it
bool isPaired();

RESOLVED

RESOLVED

Does this string need to change as well?

Removed conversion

Added

Done.

RESOLVED

its a standard c library , for that no need to comment. using ceil() function

good comment,
will do in the next release

These are not dynamic texts, and calculating the width is not necessary.
Please look at the implemented UI and set the width of each column as a constant value.
You can then also delete textMetrics.
Please note that it should have started with '_' if we were going to keep it.

Generally, please avoid these types of calculations.

I suggest doing --enable-update-mode (all lowercase) to be consistent with the other params

I made myself the moderator to close the review after I was done with my 100% no comment left completed review.

Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

The name of the component is not clear.
I think we could use the same name as before, "SliderCreateTreatment.qml"