RESOLVED in CODE WALKTHROUGH.
remove Image componenet
it is used for publish function in the bottom of this function publishAirPumpData();
RESOLVED
done
fixed. thanks
RESOLVED IN CODE WALKTHROUGH.
Is there a reason we cannot merge the two PreTreatmentCreate.qml and PreTreatmentCreateContent.qml in one PreTreatmentCreate.qml file?
Done
Please always use spaces before and after the not ( "!" ) character.
Should we update group names (RO to FP)?
Resolved.
this is not the place to define the content of the headerbar as we discussed. if possible keep the code in your tmp or any....
when value changed when value is less than minimum set to minimum
File Renamed and logic updated. RESOLVED.
Done.
RESOLVED.
For now we can use the pointer, and we will investigate on this. RESOLVED.
update to clear after validation fail when you re edit
updated.
i kept the default the same as it was so other components will not be changed
updated
Remove leading and trailing spaces in if conditionals to keep style consistent.
removed
Removed
Use #define macros for magic numbers.
We do not need to set result here since it is already set to run state at top of this function.
I don't think anything other than the container, and [ id or objectName ] should be in the object definition dictionary. If, as an example, the passwordCharacter is changed to #, the object cannot be found. same for echoMode.
Alarm should be handled inside of setAirPumpState().
else shouldn't we go back to waiting for an update or something? Seems wrong to just get stuck here.
Added
Add blank line after declarations.
Should be only one blank line here.
Remove TODO comment since you have done it.
What is difference between P coefficient and P term a few lines above?
No this is command schedules the entire zero command sequence while the other embedded mode commands are atomic.
Too many () after &&?
Rename these per f/w refactoring changes.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
