•  

Comment Results

Review Name Created Custom Fields Content
RO-LDT-566-1 25 Jun 2025

fixed

LEAHI-TD-FIRMWARE-LDT-3126-1 25 Feb 2026

Why NUM_OF_?

RO-LDT-566-1 25 Jun 2025

got it. fixed

RO-LDT-566-1 30 Jun 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-1026-1 25 Jun 2025

This is the old CR and will be reviewed and completed in the following:
http://devapps.diality.us:8060/cru/LEAHI-APPLICATION-LDT-1021-1

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

What message is this API implementing?
Why is the MESG_ID the same as the bubble?

LEAHI-DD-FIRMWARE-LDT-2030-2 12 Feb 2026

Resolved. Thanks

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

RESOLVED

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

RESOLVED

LEAHI-DD-FIRMWARE-LDT-2030-2 12 Feb 2026

declared in the header and updated them.

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

RESOLVED

LEAHI-TD-FIRMWARE-LDT-2749-1 12 Feb 2026

updated.

LEAHI-APPLICATION-LDT-1021-1 29 Jun 2025

Add one empty line before dataAppend.

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

typo - used.

RO-LDT-566-1 30 Jun 2025

newer files and groups have FP. Those that have RO will be refactored in next branch

RO-LDT-566-1 30 Jun 2025

im unsure. I thought they would be needed later for an alarm ( at least for error count ). Id like to keep them until we know they are no longer needed

RO-LDT-566-1 30 Jun 2025

fixed. thanks!

RO-LDT-566-1 30 Jun 2025

fixed. thanks!

RO-LDT-566-1 25 Jun 2025

Remove extra blank lines.

LEAHI-APPLICATION-LDT-853-1 11 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 30 Jun 2025

I cannot control Sean changing his mind on naming (it used to match). Adjusted naming to match TD FW

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

fixed!

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

removing for now and moving to other story

LEAHI-SW-LDT-627-1 30 Jun 2025

Please change this to "floater".

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

This must be unsigned.

LEAHI-APPLICATION-LDT-1021-1 01 Jul 2025

please fix the indent.

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

Set it to 0.800
RESOLVED

LEAHI-APPLICATION-LDT-907-1 08 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-907-1 07 Jul 2025

translate string with qsTr()

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

Please refactor this property.
Properties should not start with a Capital letter.

Do the same for the following in VTreatmetnRanges{.h,.cpp}

  • TrancembrncPressureLimitWindow
  • TrancembrncPressureMonitor
LEAHI-APPLICATION-LDT-1209-1 15 Jul 2025

Updated all files to reflect the name change

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

remove

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

remove

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

remove expand logic

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

REMOVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

ADDED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

REMOVED

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

RESOLVED.

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

updated

DG-DEN-14497-1 11 Jan 2023

Done

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Do we need markers for first/last DD and IOFP floats?

DG-DEN-14497-1 11 Jan 2023

It is aligned.

RO-LEAH-1972-1 22 Jan 2025

Fixed.

DIALIN-DEN-14497-1 11 Jan 2023

Why not? Don't we want to say something about it for our Dialin documentation?

DIALIN-DEN-14497-1 11 Jan 2023

Done

RO-LEAH-1972-1 22 Jan 2025

Done.

DIALIN-DEN-14497-1 11 Jan 2023

Done

DIALIN-DEN-14497-1 11 Jan 2023

RESOLVED.

DIALIN-DIAL-276-1 24 Aug 2023

yes it does. bool is a subclass of int in native python and the parameter is a union with bool

def integer_to_bytearray(val: Union[int, bool]) -> bytes: