•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-3126-1 27 Feb 2026

Updated

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

done.

LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025

When we choose something from the 3 dot prescription menu we first check if parameters are validated. If so then we do the doCancel to notify FW and then go back to the re-validate state which sets everything to be editable for any option chosen.

For the actualIndex i see the confusion but that was to offset teh index when the 'Edit Rx' is removed from the model. I updated to compare the text of the model activated so we no longer have to monitor the index. This works regardless of what model is present

LEAHI-DD-FIRMWARE-LDT-2198-1 16 Sep 2025

Align comments.

LEAHI-TD-FIRMWARE-LDT-3126-1 27 Feb 2026

Updated

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

updated and now added a overwridden setData() method to update the QAbstractListModel and emit the changes so the qml updates accordingly

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

Please keep the ipValidator, to be consistent, and in case later need to reuse the entries for the static.

RO-LDT-566-1 25 Jun 2025

Looks like no longer needed/used. Remove?

LEAHI-APPLICATION-LDT-853-1 26 Jun 2025

Make this a simple component, as in the above comment.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

added more check blocks

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

For now we can use the pointer, and we will investigate on this.
RESOLVED.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

updated to parse and do nothing

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

RO-LDT-1809-3 13 Aug 2025

Forgot this during cleanup.
Removed, Thanks

LEAHI-TD-FIRMWARE-LDT-1840-1 12 Feb 2026

There is no override for the TMP long filtered pressure value. Please add a new one for it.

LEAHI-TD-FIRMWARE-LDT-2749-1 12 Feb 2026

It was typo. Updated it.

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

Fixed. thanks!

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch of functions and trigger a s/w fault if it's invalid.

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

There are recent changes done on FPGA register in staging for B1.0/B1.9. please merge the latest changes here.

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

Add valve details per HDD (may be 2.0 valves. as we remove beta 1/1.9 in sometime)

DG-DEN-14101-1 03 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14086-1 05 Jan 2023

Assignment statements.

DG-DEN-13946-1 09 Jan 2023

Removed.

DG-DEN-13946-1 09 Jan 2023

Remove blank line.

DG-DEN-13946-1 10 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14497-1 05 Jan 2023

Use get function for override.

DG-DEN-13946-1 09 Jan 2023

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typedef THERMISTORS_TEMP_SENSORS_T. Changed load cells to use U08 to be consistent with temperature and pressure monitoring.

Should probably change temperature, pressure and load cells to use correct typedef.

Also, it looks like why the typedefs weren't used was in order to set the initial value of the iterator to 0 (i.e, the first sensor in the list). Seems like there should be a value that is the first item in the list, i.e. TEMPSENSORS_FIRST_SENSOR.

DG-DEN-13946-1 10 Jan 2023

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum).
Could also create a redundant 0 enum like below and use the "first" enum to initialize a loop iterator safely:
enum list
{
FIRST_TEMP_SENSOR = 0,
TPI_SENSOR = FIRST_TEMP_SENSOR,
TPO_SENSOR,
TD1_SENSOR,
....
}
RESOLVED in CODE WALKTHROUGH.

UI-DEN-13053-1 10 Jan 2023

This branch won't need to be merged since it has been cherry-picked for the new Qt 5.15.10 on its dedicated branch.

HD-DEN-14497-12 10 Jan 2023

Done

HD-DEN-14497-12 10 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14497-1 10 Jan 2023

Remove extra blank line.

DG-DEN-14497-1 10 Jan 2023

Keep a blank line between declarations and code.

DG-DEN-14497-1 10 Jan 2023

Keep blank line between declarations and code.

DG-DEN-14497-1 10 Jan 2023

Keep blank line between declarations and code.

DG-DEN-14497-1 10 Jan 2023

Keep blank line between declarations and code.

DG-DEN-14497-1 10 Jan 2023

Keep blank line between declarations and code.

DG-DEN-14497-1 10 Jan 2023

Keep blank line between declarations and code.

DG-DEN-14497-1 10 Jan 2023

Keep blank line between declarations and code.

DG-DEN-14497-1 10 Jan 2023

Keep blank line between declarations and code.

DG-DEN-14497-1 10 Jan 2023

Keep blank line between declarations and code.

HD-DEN-14497-12 11 Jan 2023

Done

HD-DEN-14497-12 11 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14497-12 11 Jan 2023

Done

DG-DEN-14497-1 11 Jan 2023

Done

DG-DEN-14497-1 11 Jan 2023

Done

DG-DEN-14497-1 11 Jan 2023

Done

DG-DEN-14497-1 11 Jan 2023

Done

DG-DEN-14497-1 11 Jan 2023

Done

DG-DEN-14497-1 11 Jan 2023

Done