•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Should say "... the RO conductivity ..." here for specificity.

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Should say "override RO conductivity ..." here for specificity.

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Should be "Constructs and sends an RO levels data broadcast interval override command message."

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Should say "... the RO conductivity ..." here for specificity.

RO-LDT-566-1 25 Jun 2025

Need comments for each enum

RO-LDT-566-1 25 Jun 2025

Remove blank line.

RO-LDT-566-1 25 Jun 2025

Remove extra blank line.

RO-LDT-566-1 25 Jun 2025

Remove blank line.

RO-LDT-566-1 25 Jun 2025

Remove extra blank line.

RO-LDT-566-1 25 Jun 2025

Remove extra blank line.

RO-LDT-566-1 25 Jun 2025

Fix all copy/paste issues.

LEAHI-APPLICATION-LDT-1788-1 12 Aug 2025

I have heard that we may not have an image for all the alarms; therefore, it is possible to have a blank image, and the default image may not be appropriate.
Please modify the code not to use any image when none is assigned for that ID.
Please do not use any empty image or white background image. (just no image at all)

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

removed

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

updated

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

keep slider behavior the same min to max. When min value enabled left arrow and when pressed then set to "OFF"

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

I dont think the file or the versioning it if we plan to have the same SW version for the DD/IOFP. Dialin will always display the same version # for both sub systems.

HD-DEN-15980-1 23 Aug 2023

Done

HD-DEN-14007-2 02 Jan 2023

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-15980-1 24 Aug 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Is there a reason why a few payloads are defined here while most are defined in the associated unit's header file?
If we want to define payloads here, shouldn't we define them all? And we would want to wrap each payload in a doxygen group so that they get documented in the write place.

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Needed?

HD-DEN-14086-1 05 Jan 2023

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-14497-12 05 Jan 2023

FALSE was correct (throughout) for last param of sendAckResponseMsg() if message/request found to be invalid in some way, TRUE if message is ok.

RO-LEAH-1972-1 22 Jan 2025

I guess this need to be cleaned up for RO.

HD-STT-1965-1 25 Aug 2023

So override is a one-shot thing. It gets reset after first use? Tester must override multiple times to trigger time windowed alarm?

HD-STT-1965-1 25 Aug 2023

Add space between ( and TRUE.

RO-LEAH-1972-1 22 Jan 2025

Please update the naming order.

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

done.

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

DG should be RO.

LEAHI-APPLICATION-LDT-2160-1 12 Sep 2025

RESOLVED

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

Please use your newly defined units in the Variables for the K and Ca.

LEAHI-TD-FIRMWARE-LDT-1840-1 12 Feb 2026

Updated

LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED.

LEAHI-TD-FIRMWARE-LDT-1840-1 12 Feb 2026

Passed tmpPres

RO-LDT-566-1 25 Jun 2025

fixed

LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED

RO-LDT-566-1 25 Jun 2025

fixed

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

set "OFF" when value is 0

RO-LDT-566-1 25 Jun 2025

Remove extra ";".

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

look into previous design for behavior when this is enabled what gets disabled.

RO-LDT-566-1 25 Jun 2025

fixed

RO-LDT-566-1 25 Jun 2025

fixed

RO-LDT-566-1 25 Jun 2025

Remove extra space(s) before = or align with = above.

RO-LDT-566-1 25 Jun 2025

Use 0.0F for floats.

RO-LDT-566-1 25 Jun 2025

Function names don't match.

LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

revert back to null

LEAHI-TD-FIRMWARE-LDT-1903-8 25 Feb 2026

I think we have to include a comment specifying what function is being used from this file.

RO-LDT-566-1 25 Jun 2025

Add blank line before a /// comment. I don't think doxygen handles correctly w/o blank line above.

LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED