•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-16093-1 23 Aug 2023

RESOLVED.

HD-STT-2897-1 23 Aug 2023

Changed to persistence functions. Has been pushed to develop and tested.

DG-DEN-16280-1 24 Aug 2023

We don't trigger inlet water conductivity alarm in post-treatment mode? Any reason why we're not just saying "== MODE_POST"? What about inlet water pressure/temperature?

FYI - getHDOperationMode() was not working - HD op mode handler was mishandling message - fixed in my DENBUG-59 branch, but not yet in staging.

HD-DEN-15980-1 22 Aug 2023

Please check comment column alignment

HD-DEN-15980-1 23 Aug 2023

useShortStablizeTime is an input, not output (and is mis-spelled).

DIALIN-DIAL-276-1 24 Aug 2023

Does integer_to_bytearray() work correctly on bools?

HD-STT-1965-1 25 Aug 2023

Corrected

DG-DEN-15973-1 25 Aug 2023

Corrected

DG-DEN-15973-1 25 Aug 2023

The ROPump PWM is set from 5 different calls. Doesn't look like there is a global indicating the last set PWM value (could add). The execROPumpMonitor function might be a good place to put the check as it looks to be able to handle different modes, but again doesn't have access to the last set PWM value.

DG-DEN-15973-1 23 Aug 2023

Put declarations at top of function. Use our BOOL type. Put ternary in ().

DG-DEN-15973-1 28 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14007-2 02 Jan 2023

Fixed.

DIALIN-DEN-14197-1 29 Dec 2022

Function name and brief suggest we are overriding fill target volume but message enum suggests we are overriding the integrated volume from flow that we use to check load cell vs. flow sensor for each fill. I think latter is correct. Should rename function and update brief to clarify purpose.

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Do we even need a FPCommon.h?

HD-DEN-14086-1 05 Jan 2023

Alignment

LEAHI-APPLICATION-LDT-1616-1 24 Sep 2025

RESOLVED

LEAHI-DIALIN-LEAH-142-2 16 Dec 2024

Fixed. Thanks!

DG-DEN-15634-1 09 Aug 2023

Move blank line down one.

LEAHI-DIALIN-LEAH-142-2 10 Dec 2024

Typically, handlers are positioned above command functions.

UI-DEN-15918-3 10 Aug 2023

I resolved my own message because of the conversation we had in terms of why I am making the change suggested.

UI-DEN-15918-3 10 Aug 2023

Changed as requested

RO-LEAH-1972-1 16 Jan 2025

Not clear to me yet. I suspect descaling will be part of a heat disinfect. Not sure if there will be other disinfection modes.

UI-DEN-15918-3 10 Aug 2023

After our conversation, I have changed as requested.

LEAHI-DIALIN-LDT-2300-1 25 Sep 2025

Done - timestamps added to DD, FP, and TD

UI-DEN-16123-5 14 Aug 2023

save as the other one.

UI-DEN-16123-6 14 Aug 2023

No, that branch change had gone in already. The check was added in the log() and not here.

DIALIN-DIAL-280-1 18 Aug 2023

id 63 is ALARM_ID_AVAILABLE_20

DIALIN-DIAL-277-1 21 Aug 2023

RESOLVED.

HD-DEN-16093-1 21 Aug 2023

I think we have been trying to have these types of message IDs end in "_CMD_REQUEST".

RO-LEAH-1972-1 22 Jan 2025

Done.

DG-DEN-15973-1 23 Aug 2023

No point to having non-zero clear persistence - it's a fault.

RO-LEAH-1972-1 22 Jan 2025

Fixed.

RO-LEAH-1972-1 22 Jan 2025

CPI, CPO to be referred as P9 and P18? when the code is uncommented, there is a possibility of leaving CPI/CPO as it is.

RO-LEAH-1972-1 22 Jan 2025

Just to be consistent, can we change it to p7Flow (instead of FlowP7)? same for P16flow.

LEAHI-DIALIN-LEAH-136-2 22 Jan 2025

Remove.

LEAHI-DIALIN-LEAH-136-3 22 Jan 2025

Rename these per f/w refactoring changes.

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

These temperatures were moved to temperature sensors broadcast msg and should be captured in the temperatures class (when you create it) instead of here.

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Should say "... the RO conductivity ..." here for specificity.

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Should say "override RO conductivity ..." here for specificity.

LEAHI-DIALIN-LEAH-136-3 22 Jan 2025

Rename these per f/w refactoring changes.

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Remove "(measured))".

LEAHI-DIALIN-LEAH-136-3 22 Jan 2025

Rename these per f/w refactoring changes.

RO-LDT-566-1 25 Jun 2025

fixed

RO-LDT-566-1 25 Jun 2025

fixed

RO-LDT-566-1 25 Jun 2025

fixed

RO-LDT-566-1 25 Jun 2025

Add blank line before banner.

RO-LDT-566-1 25 Jun 2025

Remove blank line.

RO-LDT-566-1 25 Jun 2025

fixed

RO-LDT-566-1 25 Jun 2025

Remove extra ";".

RO-LDT-566-1 25 Jun 2025

fixed