•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-13946-1 06 Jan 2023

Why change this to U08?

RO-LEAH-262-1 25 Nov 2024

Done.

HD-DEN-15741-2 03 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15996-1 03 Aug 2023

Done.

HD-DEN-15741-2 02 Aug 2023

Change postponed for further testing. No change in DialIn.
Done.

RO-LEAH-262-1 25 Nov 2024

function body still mentioning pressure.

HD-DEN-15741-2 03 Aug 2023

Done.

HD-DEN-15741-2 03 Aug 2023

Call these blocked functions once and save values to local vars. Use local vars throughout function so you don't have to keep calling the functions.

Also, why are we looking at blood recirc at all? BP is never on in recirc states so no need to manage blocking blood recirculation.

HD-DEN-15741-2 03 Aug 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15741-2 04 Aug 2023

Done.

HD-DEN-15741-2 04 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15741-2 04 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15634-1 08 Aug 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15196-5 08 Aug 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-DIALIN-LEAH-142-2 16 Dec 2024

This is a dictionary, so its by name.

DG-DIAL-273-1 08 Aug 2023

Fixed. Thanks!

DG-DIAL-273-1 08 Aug 2023

Fixed. Thanks!

DG-DEN-14692-1 15 Aug 2023

Fixed. Thanks!

LEAHI-DIALIN-LEAH-142-2 16 Dec 2024

This is a dictionary so the key is by name

LEAHI-DIALIN-LEAH-142-2 10 Dec 2024

vlv_name should be vlv_id?

LEAHI-DIALIN-LEAH-142-2 16 Dec 2024

Fixed. Thanks!

LEAHI-DIALIN-LEAH-142-2 10 Dec 2024

hd should be td OR just removed - no need to say TD since there is only one air trap in the system which belongs to the TD.

HD-DENBUG-285-1 18 Dec 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15634-1 09 Aug 2023

Move blank line up one.

HD-DENBUG-285-1 18 Dec 2024

Delete the #define if not using it anymore.

DG-DEN-15634-1 09 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DG-DENBUG-59-1 09 Aug 2023

For DG, it's not used (yet at least). But there are common macros that call this function, so had to change HD and DG versions of this function.

DG-DEN-14692-1 15 Aug 2023

Please remove the blank line.

TD-LEAH-1970-1 16 Jan 2025

Fixed.

HD-DENBUG-59-1 11 Aug 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14815-1 11 Aug 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14815-1 10 Aug 2023

Add currentPostTreatmentState to header

UI-DEN-15918-3 08 Aug 2023

we already have the same variable define as Settings_Path_Name.
Please use that

UI-DEN-15918-3 13 Aug 2023

RESOLVED

UI-DEN-15918-3 08 Aug 2023

please add //DEBUG

UI-DEN-16123-6 14 Aug 2023

Per the recent I/O failed ticket, we need to also do handle the write fail here similar to how we did there. Should we add it here now or open a ticket for later ?

DG-DEN-14692-1 16 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16200-1 16 Aug 2023

Done.

HD-DEN-16200-1 16 Aug 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-16200-1 15 Aug 2023

Add syringePumpStateStartTime to header.

HD-DEN-15994-1 17 Aug 2023

As you pointed out earlier, rinsebackTimerCtr is set to zero in states where BP is running, so the if condition would only be TRUE (rinsebackTimerCtr > 0) if BP is not running.

DG-DIAL-280-1 18 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16164-1 18 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14706-1 18 Aug 2023

Override should be OR'd with timeout only. Used should have to be true even if override > 0.

HD-DEN-14706-1 18 Aug 2023

Fixed. Thanks!

DG-DIAL-280-1 18 Aug 2023

Fixed. Thanks!

DG-DIAL-280-1 18 Aug 2023

Add blank line between banner comment and prototype.

DIALIN-DIAL-277-1 18 Aug 2023

Moved to hd/buttons. Thanks!

DIALIN-DIAL-280-1 18 Aug 2023

RESOLVED

DG-DEN-14706-1 18 Aug 2023

Suggest aligning comments in the block above