•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15741-2 03 Aug 2023

Done.

RO-LDT-566-1 25 Jun 2025

fixed.

HD-DEN-15741-2 03 Aug 2023

RESOLVED in CODE WALKTHROUGH.

RO-LDT-566-1 25 Jun 2025

fixed.

HD-DEN-15741-2 03 Aug 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15634-1 08 Aug 2023

Fixed. Thanks!

HD-DEN-15885-2 08 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15634-1 07 Aug 2023

Align comment

HD-DEN-15993-1 08 Aug 2023

Updated.

HD-DEN-15741-2 04 Aug 2023

Done.

HD-DEN-15741-2 03 Aug 2023

Blank line before banner comment.

HD-DEN-15741-2 04 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DG-DIAL-273-1 08 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15634-1 09 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DG-DENBUG-59-2 09 Aug 2023

Local logging is a future requirement. Some work was done long ago before we knew it wasn't needed yet. #ifdef added to prevent compiler warnings about non-usage.

DG-DENBUG-59-1 09 Aug 2023

That's what it looked like when reviewed HD side.

RESOLVED IN CODE WALKTHROUGH

DG-DENBUG-59-1 09 Aug 2023

Where is outside used?

HD-DENBUG-59-1 11 Aug 2023

Removed.

DG-DEN-16215-1 16 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DG-DENBUG-59-2 09 Aug 2023

Should queueFrontIndex be added to header? Is ENABLE_LOCAL_LOGGING only for testing purposes?

UI-DEN-15918-3 11 Aug 2023

Please remove this as well, regarding the changes made in CPP

UI-DEN-15918-3 13 Aug 2023

RESOLVED

UI-DEN-15918-3 13 Aug 2023

RESOLVED

UI-DEN-16123-5 14 Aug 2023

Did you purposely leave this commented out?

UI-DEN-16123-6 14 Aug 2023

RESOLVED per convo.

UI-DEN-16123-4 11 Aug 2023

missing if braqckets

HD-DEN-15994-1 16 Aug 2023

You removed the if (great), but I don't see that you replaced it with BP stopped check. I don't think we want a countdown if BP is running (blood not sitting).

HD-DEN-15994-1 16 Aug 2023

This if will prevent countdown timer from being displayed unless we are paused or stopped after rinseback. I think countdown timer is definitely needed for rinseback init state (pump is stopped and rinseback hasn't even started). May be needed for new reconnect patient state as well.
I think it might be simpler/clearer to replace this if with a check for whether BP is running or not. If BP is stopped, we proceed to next if. If BP is running, keep timeouts at zero.

HD-DEN-16164-1 17 Aug 2023

Updated to handle any active alarm if we havent passed pressure tests. I also modified the logic to where this valve change should only happen in d.s.p.t.

HD-DEN-16164-1 17 Aug 2023

dryPressureTestsCompleted is already in this header. dryPressureTestsCompleted was added to setupForSelfTestStop() header.

HD-DEN-16164-1 18 Aug 2023

RESOLVED IN CODE WALKTHROUGH

DIALIN-DIAL-280-1 18 Aug 2023

Fixed. Thanks!

DG-DEN-14706-1 18 Aug 2023

Removed #define. Thanks!

DG-DEN-14706-1 21 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15980-1 24 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16093-1 22 Aug 2023

Updated.

HD-DEN-16093-1 22 Aug 2023

Rename function to name of state (like others).

HD-STT-2897-1 23 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15980-1 22 Aug 2023

Why set to false here? Seems like if statement in next state will always be false now.

DIALIN-DIAL-276-1 25 Aug 2023

RESOLVED.

DG-DEN-16093-1 25 Aug 2023

Done.

DG-DEN-15973-1 25 Aug 2023

Corrected

DG-DEN-16093-1 25 Aug 2023

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is reduced, this level should also be reduced accordingly."

DG-DEN-15973-1 28 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-16309-1 28 Aug 2023

RESOLVED.

LEAHI-TD-FIRMWARE-LDT-3126-1 25 Feb 2026

Added back

RO-LEAH-262-1 25 Nov 2024

Done.

HD-DEN-14007-2 02 Jan 2023

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-14457-1 05 Jan 2023

Branch removed. This "bugfix" branch was created in error.

HD-DEN-15741-2 03 Aug 2023

RESOLVED in CODE WALKTHROUGH.