•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-16093-1 21 Aug 2023

required changes are done.

HD-DEN-16093-1 22 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-STT-2897-1 22 Aug 2023

Good catch. Consider replacing manual error timer counter with common persistence function.

HD-DEN-15980-1 23 Aug 2023

Updated header.

HD-DEN-15980-1 23 Aug 2023

Done

DG-DEN-16093-1 25 Aug 2023

100% now.

DG-DIAL-281-1 29 Aug 2023

Fixed. Thanks!

HD-DEN-14007-2 02 Jan 2023

Should 4000.0F be a #define. Line 112 also.

DG-DEN-14497-1 04 Jan 2023

Assume this is for testing?

HD-DEN-15741-2 03 Aug 2023

Should not go to stopped state - let state machine manage state transitions. Just stop DPi and trimmer heater.

LEAHI-DIALIN-LEAH-136-2 22 Jan 2025

Catch up with latest f/w.

DG-DEN-14706-1 18 Aug 2023

I don't see where this #define is ever used. Remove if not needed.

RO-LEAH-262-1 25 Nov 2024

Done.

HD-DEN-15980-1 23 Aug 2023

Updated

HD-DEN-15741-2 03 Aug 2023

Still more here than should be. Trimmer heater is being turned off twice now. DPo should already be stopped. And VBA/VBV should be handled by state machine I would think unless user stop requirement talks about valves too - and even if so, valves should only close when user stop alarm is active - nothing to do with recirc properties in alarms.

RO-LEAH-262-1 25 Nov 2024

Remove spaces before =0;

RO-LEAH-262-1 25 Nov 2024

please update flow rate unit and change pressure sensor to flow sensor.

DIALIN-DIAL-277-1 18 Aug 2023

DG doesn't need this specifically but this is a HD proxy command. V&V currently needs this to dismiss the prompt on the UI screen. I think in the near future we should reorganize Dialin sub modules. Maybe by overrides ( HD, DG, & UI ) and proxy messages ( DG, HD, UI ).

HD-DEN-15885-2 08 Aug 2023

Done.

HD-DEN-15885-2 08 Aug 2023

Fix alignment.

LEAHI-DIALIN-LEAH-142-2 10 Dec 2024

Should status array be index by .value instead of .name?

DG-DEN-15634-1 08 Aug 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15634-1 08 Aug 2023

Where is this function being called?

DG-DEN-15634-1 09 Aug 2023

Fixed!

LEAHI-DIALIN-LEAH-142-2 16 Dec 2024

Fixed. Thanks!

UI-DEN-15918-3 10 Aug 2023

Changed as requested

HD-DENBUG-59-1 11 Aug 2023

Fixed.

LEAHI-DIALIN-LEAH-136-2 22 Jan 2025

Remove - we don't have this in Leahi yet.

TD-LEAH-1970-1 16 Jan 2025

We may need to keep generic name of variable as 'pressure' instead of 'pressure_bar' (since it's no more converting into bar unit).

RO-LEAH-1972-1 22 Jan 2025

Done.

UI-DEN-16123-4 14 Aug 2023

for the models we keep the format as it is.

RO-LEAH-1972-1 22 Jan 2025

Done.

DG-DIAL-280-1 18 Aug 2023

Add blank line between functions.

DG-DEN-14706-1 18 Aug 2023

I think override should be OR'd with timeout only. The used condition should still have to be true even if override is in place.

LEAHI-DIALIN-LEAH-136-2 22 Jan 2025

Remove.

DG-DEN-16093-1 22 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16093-1 22 Aug 2023

Add a blank line between declarations and code.

HD-STT-1965-1 25 Aug 2023

Yes. The issue was that when the override was issued the windowed timer alarm triggered almost immediately.

HD-DEN-15980-1 22 Aug 2023

Maybe create a public #define USE_SHORT_STABILIZATION_PERIOD TRUE somewhere in PresOccl.h to make these more readable.

HD-DEN-15980-1 22 Aug 2023

This is a parameter, not an input - though there is a static variable that gets set by signal function, so not clear to me why you're not using that here instead of parameter.

HD-DEN-15980-1 22 Aug 2023

Provide parameter name in prototype.

LEAHI-DIALIN-LEAH-136-2 22 Jan 2025

Match DD op modes in f/w.

HD-DEN-15980-1 24 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-59-1 24 Aug 2023

RESOLVED IN CODE WALKTHROUGH

RO-LDT-566-1 25 Jun 2025

Should be 0.0F (with F suffix).

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Should say "override RO conductivity ..." here for specificity.

HD-STT-1965-1 25 Aug 2023

RESOLVED in CODE WALKTHROUGH.

RO-LDT-566-1 25 Jun 2025

Dont see them in the excel sheet or in the common repo.

RO-LDT-566-1 25 Jun 2025

Remove 2 extra blank lines.

DIALIN-DEN-16309-1 28 Aug 2023

We have 2 states at 11.