•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-15918-3 09 Aug 2023

For SD card case, when the SD card is not ready, we update the visuals to set the
"available" and "used" to 0 and emit the update. For this case, we are not updating
any visuals. The need we have for this function is to determine whether we are
low on available partition space and if we are, emit the "low" signal to handle

DG-DIAL-273-1 08 Aug 2023

Remove blank line.

HD-DEN-15741-2 04 Aug 2023

Keep resume behavior as it was unless Systems is telling you current behavior is wrong. recircResumeRequested flag gets set to TRUE somewhere else and I think that is the only place where the flag should be set. I see no reason why it should be set here.

HD-DEN-15741-2 04 Aug 2023

Done.

HD-DEN-15741-2 04 Aug 2023

Done.

HD-DEN-15741-2 04 Aug 2023

Done.

HD-DEN-15741-2 03 Aug 2023

Everything in this function except DPi and trimmer heater stops should already be set in transition to recirc function. Most of this is redundant.

HD-DEN-15741-2 04 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15634-1 08 Aug 2023

Fixed. Thanks!

DG-DEN-15634-1 09 Aug 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15634-1 07 Aug 2023

Add dataPublishCounter

DG-DEN-15634-1 09 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15634-1 09 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DG-DENBUG-59-2 11 Aug 2023

RESOLVED IN CODE WALKTHROUGH

UI-DEN-15918-3 13 Aug 2023

RESOLVED

UI-DEN-15918-3 13 Aug 2023

RESOLVED

UI-DEN-15918-3 08 Aug 2023

Why it is different than the same function for the SD-card?
It is a mounted drive.

UI-DEN-15918-3 13 Aug 2023

RESOLVED

UI-DEN-16123-6 14 Aug 2023

isn't it in another branch fixed by you.
if that is the case it will get merged later on staging.

UI-DEN-16123-5 14 Aug 2023

Yes that was intentional.
I don't want to expose what CRC is expected.
And could not find a good way to tag it as // DEBUG

UI-DEN-16123-6 14 Aug 2023

RESOLVED

HD-DEN-15994-1 17 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14706-1 18 Aug 2023

Fixed. Thanks!

DG-DIAL-280-1 18 Aug 2023

Fixed. Thanks!

HD-DEN-14706-1 18 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DIALIN-DIAL-280-1 18 Aug 2023

RESOLVED

DIALIN-DIAL-280-1 18 Aug 2023

Fixed. Thanks!

DG-DEN-16093-1 22 Aug 2023

#includes are sorted. Put OperationModes.h in its proper place.

DG-DEN-16093-1 22 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16093-1 21 Aug 2023

Consider following up on this command's success once we're in complete state (would need to add a handler function for complete state). There is a getDGCommandResponse() function in DGInterface that we're using for other DG commands to make sure DG got and accepted the command (and sometimes retrying if not).

HD-DIAL-278-1 22 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-16093-1 22 Aug 2023

Please change the naming of 0x83 to what you have in your latest common branch

HD-DEN-15980-1 23 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15980-1 23 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15980-1 23 Aug 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-TD-FIRMWARE-LDT-3126-1 25 Feb 2026

Updated

RO-LEAH-262-1 25 Nov 2024

Done.

LEAHI-DIALIN-LEAH-142-2 10 Dec 2024

Missing RO Dialin messages.

DG-DEN-15996-1 03 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14007-2 02 Jan 2023

Spaces around value.

HD-DEN-15741-2 03 Aug 2023

s/b recirculate. Done.

HD-DEN-14007-2 02 Jan 2023

Fixed in all 3 pump modules.

HD-DEN-14007-2 02 Jan 2023

Should 4000.0f be a #define? Line 113 also?

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

Was looking to clarify comment actually.

DG-DEN-14101-1 02 Jan 2023

Done.

DG-DEN-14101-1 02 Jan 2023

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-15741-2 03 Aug 2023

Why does this function return/set state? It is not a state handler function.

LEAHI-TD-FIRMWARE-LDT-3126-1 25 Feb 2026

Updated

HD-DEN-15741-2 03 Aug 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14086-1 05 Jan 2023

Alignment of what?