•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15993-1 08 Aug 2023

Need to do same for pump track latch.

HD-DEN-15741-2 04 Aug 2023

Done.

HD-DEN-15741-2 03 Aug 2023

I don't think you need to repeat @details Inputs: and @details Outputs:. Only need those for first row. See other functions for example.

HD-DEN-15741-2 03 Aug 2023

So this is only going to stop pumps/heater if both block recircs are active. I don't think that's what you want.
My understanding of what you're trying to do here is this:
1) if dialysate recirc is blocked by an active alarm (includes user stop alarm), we should stop DPi and HR. Otherwise, we should run DPi and HR.
2) if user stop alarm is active or we are in any state other than recirc state, we should stop BP. Otherwise, we should run BP to recirculate blood side of circuit.

HD-DEN-15741-2 04 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15994-1 04 Aug 2023

Done.

HD-DEN-15994-1 04 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DG-DIAL-273-1 07 Aug 2023

We're starting seeing a trend where V&V want to override pre-calibrated values ( like the LC structure above ). I followed the LC override style since it has similar behavior. I have no issue splitting

DIALIN-DIAL-273-1 07 Aug 2023

Fixed. Thanks!

DIALIN-DIAL-273-1 04 Aug 2023

Missing new param in header.

DG-DEN-15634-1 07 Aug 2023

Update header

HD-DEN-15196-5 08 Aug 2023

Fixed. Thanks!

DG-DEN-15634-1 07 Aug 2023

These 3 variables are not referenced

HD-DEN-15196-5 07 Aug 2023

Remove this comment.

DG-DIAL-273-1 03 Aug 2023

Update @param with raw

DG-DEN-15634-1 08 Aug 2023

Add blank line before function header.

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Remove extra blank line.

DG-DEN-14316-1 20 Dec 2022

OK, now I see. I removed this one. There are others, should I remove them also?

DG-DEN-14316-1 20 Dec 2022

Removed it this time.

DG-DEN-14316-1 20 Dec 2022

I can't find this.

UI-DEN-15833-10 01 Aug 2023

RESOLVED

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

UI-DEN-15918-2 28 Jul 2023

Done, I excluded the System.conf file specifically and added all *.dflt to the filter

LEAHI-DIALIN-LEAH-139-2 21 Nov 2024

Needs to be updated as integer - pressure sensor.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

LEAHI-DIALIN-LEAH-139-2 25 Nov 2024

baro sensor CRC -> Integer type.

DG-DEN-14316-1 21 Dec 2022

Added to group.
RESOLVED in CODE WALKTHROUGH.

DG-DEN-14307-1 21 Dec 2022

Done

DIALIN-DEN-14307-1 21 Dec 2022

Sean Nash could you please respond to this comment?

RO-LEAH-262-1 25 Nov 2024

Fixed.

DG-DEN-14307-1 21 Dec 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-15905-10 28 Jul 2023

code alignment

DG-DEN-14307-1 21 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14307-1 21 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14307-1 21 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 30 Nov 2022

Remove blank line.

DIALIN-DEN-14307-1 21 Dec 2022

RESOLVED

LEAHI-DIALIN-LEAH-142-2 16 Dec 2024

RO messages are in the RO branch

LEAHI-DIALIN-LEAH-142-2 10 Dec 2024

Remove blank line.

HD-DENBUG-62-1 02 Aug 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 22 Dec 2022

Referring to manual alarm info table below. It looks correct.
RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 21 Dec 2022

Can't have gaps in alarm enum/tables - will not compile. Need to pull in alarms from other branches if necessary to fill the gaps.

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Should say "RO conductivity ..." here for specificity.

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-14344-1 22 Dec 2022

RESOLVED.

DIALIN-DEN-14344-1 22 Dec 2022

RESOLVED.