•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-15905-10 28 Jul 2023

yes, to easily checkout on all the relevant repositories.

DG-DEN-14316-1 21 Dec 2022

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-250-1 19 Nov 2024

I haven't done this unit yet - just brought it over from DD. I'll comment out for now.

RO-LEAH-250-1 19 Nov 2024

Update outputs and params

UI-DEN-15833-10 28 Jul 2023

please align
SIGNAL(did
SLOT( on

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

Make width of content as wide as pposible. takes in 64 characters

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

Look into how to turn off when value is set

UI-DEN-15918-2 28 Jul 2023

the Settings/Systems.conf cannot be checked for checksum,
it is user preference and will change, therefore will fail the checksum.

DG-DEN-14316-1 21 Dec 2022

I don't know the answer to this question.

UI-DEN-15905-12 01 Aug 2023

added

DG-DEN-14316-1 21 Dec 2022

I don't understand the question. Appears to be publishing data now.

DG-DEN-14307-1 20 Dec 2022

Need a default case with s/w fault.

DG-DEN-14316-1 21 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14307-1 20 Dec 2022

Remove extra blank line.

LEAHI-TESTSUITES-LDT-3060-1 25 Feb 2026

changed as per comment mouseClick(utility.findChildByText(main_menu_container, "Treatment"))

DG-DEN-14307-1 21 Dec 2022

RESOLVED IN CODEWALKTHROUGH.

UI-DEN-15918-2 28 Jul 2023

Added

UI-DEN-15833-6 28 Jul 2023

for arterial and venous pressure values we align them to the right.
this is correct.

DIALIN-DEN-14307-1 21 Dec 2022

RESOLVED

DIALIN-DEN-14344-1 22 Dec 2022

RESOLVED.

RO-LEAH-250-1 20 Nov 2024

In RODefs.h -> please change RO_POST_STATES enum members to RO_POST_STATE_START.. etc., ( instead of POST_STATE_START). seeing conflict with TDDefs.h post states.

UI-DEN-15905-12 02 Aug 2023

RESOLVED

UI-DEN-15905-12 01 Aug 2023

Please add //DEBUG

HD-DEN-15741-2 01 Aug 2023

I reviewed DEN-15741 which is re: desire to stop DPi if user stopped with button.
Everything I see changed in this module seems like a very complicated way to achieve that using properties that I don't think were intended for this.
I think all we needed to do was check if user stop alarm is active and, in that special case, stop DPi instead of recirculating dialysate like it usually does in the recirc stop state.

LEAHI-DIALIN-LEAH-139-2 21 Nov 2024

Its priority interval (not general task )

LEAHI-TD-FIRMWARE-LDT-1840-1 12 Feb 2026

Shouldn't use .data here. TMP should be passed into this function like art and ven pressures and we should use the parameter here instead of .data.

LEAHI-TD-FIRMWARE-LDT-1903-8 26 Feb 2026

fixed

LEAHI-TD-FIRMWARE-LDT-1903-8 26 Feb 2026

in other files when they use string and/or math headers they had specified a comment describing which functions are used from the headers.

RO-LDT-566-1 25 Jun 2025

I believe these are in the correct format. is there something missing?

RO-LDT-1242-1 04 Sep 2025

reverted commit. Back to 110 ranking and changed properties for DD fault = TRUE

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

Add a TODO to comment then.

RO-LDT-566-1 25 Jun 2025

yes

RO-LDT-566-1 25 Jun 2025

fixed

RO-LDT-566-1 25 Jun 2025

Remove extra blank line.

RO-LDT-566-1 25 Jun 2025

Function names don't match.

RO-LDT-566-1 25 Jun 2025

Remove blank line.

RO-LDT-566-1 25 Jun 2025

Add "F" suffix to 0.0.

RO-LDT-566-1 25 Jun 2025

Inputs should be none.

RO-LDT-566-1 25 Jun 2025

Add blank line before next function.

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

RESOLVED

LEAHI-TD-FIRMWARE-LDT-3126-1 25 Feb 2026

Is this really a timer counter? Looks like a flow rate.

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

RESOLVED

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

Add as HDF hallsensor. start the comment with capital letter R.

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

fixed

LEAHI-DIALIN-LDT-566-1 25 Jun 2025

Should we be logging anything?

LEAHI-DIALIN-LDT-566-1 25 Jun 2025

Wrong msg ID.

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

Got it!
Thanks!
RESOLVED

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

either typecast pwmInCount as U08 while passing to FPGA or declare the variable size as U08 instead of U32.

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

added

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025