RESOLVED in CODE WALKTHROUGH.
These changes are in staging right now. Do we have to stop dialysis in this state?
Was this intentionally added for the pre-build steps ?
No Drain pump pressure sensor.
I assume Vinay is talking about which variables you are specifying for Inputs and Outputs. e.g. boostPumpControlMode is an input, but not in list.
These pressure sensors ID needs to be updated (repeated in entire file)
Typo in conductivity.
this has been reverted back to original
this has been updated to use doInitWifiInfo
fixed
RESOLVED
removed
fixed. thanks!
reverted it back to S32. Added S32 overrides as well.
Why are these flow rates floats if FPGA is giving us integers?
enum name is too generic. Add TEMP to name or remove (I don't think enum name is needed if it's a typedef).
RESOLVED.
Confirmed this will be made vertical layout and separated. It should fit given 4 messages are still to be added (air pump, air bubbles, pressures, opmode)
fixed!
removing for now and moving to another story
Please do not wrap the lines. Align the .setText and parentheses.
align
Add the reset and send buttons.
Same here: http://devapps.diality.us:8060/cru/#LEAHI-APPLICATION-LDT-853-1CFR-69103
RESOLVED IN CODE WALKTHROUGH.
Done
The latest source file has updated heaters exec state. please update accordingly.
I spoke with Blaine, he said make them consistent and defer to Sean. So they will both be as HD was - No re-trigger in Rinseback or End TX.
Replace to RO_FPGA_COMPATIBILITY_REV. check the below commented alarm as well.
Need default case with s/w fault.
Fixed.
Fixed?
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
