•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-1021-1 23 Jun 2025

The copyrights of the file will be automatically updated when it is built.
Therefore, there is no need to update them manually.

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

RESOLVED

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

RESOLVED

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

RESOLVED

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

updated

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

why this one is H6 not H4, which does not match the application.

LEAHI-APPLICATION-LDT-1021-1 29 Jun 2025

RESOLVED

RO-LDT-566-1 25 Jun 2025

No longer plural.

RO-LDT-566-1 27 Jun 2025

Remove extra blank line.

HD-DEN-15660-1 13 Jul 2023

This part of code has been removed.

HD-DEN-14307-1 21 Dec 2022

Done

DG-DEN-15702-1 13 Jul 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14307-1 21 Dec 2022

RESOLVED IN CODE WALKTRHOUGH.

UI-DEN-15279-1 17 Jul 2023

RESOLVED

UI-DEN-15279-5 17 Jul 2023

exits -> exists ?

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

HD-DENBUG-64-1 18 Jul 2023

Move up with other setup functions.

DD-LEAH-236-1 14 Nov 2024

Done.

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 21 Dec 2022

Leaving as is for now. Will review all msg IDs later.
RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-64-1 18 Jul 2023

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-236-1 14 Nov 2024

ModeGenDialysate should move up before ModeInitPOST to be in alphabetical order.

DG-DEN-14316-1 21 Dec 2022

I went through it again, and changed a number of them.

HD-DEN-15664-1 20 Jul 2023

We should send this countdown msg from a publish function that gets called by exec function for treatment end only once per second (see how this msg is sent by rinseback mode for example).
And should send the message all the time. If in the wait for rinseback state, just send zeroes (and UI won't show countdown). If in paused state, always send 300 seconds for timeout and 300-(bloodSittingTimerCtr / 20) for countdown (don't let it go negative or wrap though). If an alarm dialog is being displayed, it should show the countdown for the whole 5 minutes (not just the last minute after warning).

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 21 Dec 2022

chemDisinfectFlushUIState is set in a number of places, but it was not set in the publish logging data function. I corrected that.

HD-DEN-14307-1 20 Dec 2022

All of these terms are integers and cast is coming too late (after division). To prevent loss of precision on division, we want to cast both sides of the division as floats.

DG-DEN-14307-1 21 Dec 2022

Done

UI-DEN-15833-4 25 Jul 2023

That was pre-existing and unrelated to the changes I had made for this CR.

DG-DEN-14307-1 21 Dec 2022

Done

DG-DEN-14307-1 20 Dec 2022

Add a comment to explain why this is here.

DG-DEN-14316-1 21 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-15536-1 24 Jul 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14307-1 21 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

R1FullVolume and R2FullVolume are set here but aren't referenced.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

updated and added new READONLY for ssid

DG-DEN-14307-1 21 Dec 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-15905-2 24 Jul 2023

RESOLVED

UI-DEN-15905-2 21 Jul 2023

I am assuming you are purposely adding "treatmentBackClicked" signal for clarity here? The back signal from the base (EndTreatmentBase) can be detected as part of the EndTreatmentRinseBackConnect Item.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

this has been reverted and added a FIXME instead to address later

DG-DEN-14316-1 21 Dec 2022

prevChemDisinfectFlushState is not used.

DG-DEN-14316-1 21 Dec 2022

drainTimer, numberOfPostDisinfectRinses, rsrvFillFillToFullStableTimerCounter

HD-DEN-14307-1 21 Dec 2022

RESOLVED IN CODEWALKTHROUGH.

HD-DEN-14307-1 21 Dec 2022

RESOLVED IN CODEWALKTHROUGH.

HD-DEN-14307-1 21 Dec 2022

RESOLVED IN CODEWALKTHROUGH.

UI-DEN-15896-1 24 Jul 2023

we wanted to be consistent with the other two for W:<wireless> and E:<ethernet> and now to be B:<Bluetooth>

RO-LDT-566-1 25 Jun 2025

Remove extra blank line.

LEAHI-DIALIN-LDT-566-1 25 Jun 2025

fixed. thanks