•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-15702-1 12 Jul 2023

Remove gap before "=" as alignment no longer relevant.

DG-DEN-14316-1 21 Dec 2022

It is definitely in the code.

DG-DEN-14316-1 21 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

UI-DEN-15279-1 17 Jul 2023

[~pvedantam],
Will work on this on the tickets we have for the boot up performance improvement.

UI-DEN-15279-1 17 Jul 2023

fixed

LEAHI-TD-FIRMWARE-LDT-1840-1 12 Feb 2026

This looks wrong.

UI-DEN-15279-1 17 Jul 2023

updated.

HD-DEN-14344-3 22 Dec 2022

Fixed. Thanks!

TD-LDT-1886-7 29 Sep 2025

Remove extra blank line.

HD-DEN-14344-3 22 Dec 2022

Fixed? There is a blank line here

UI-DEN-15279-5 17 Jul 2023

RESOLVED

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-250-1 19 Nov 2024

True. For now I am assuming both pumps will have the same max and so I have a common #define.

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-15279-1 17 Jul 2023

RESOLVED

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 22 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

UI-DEN-15279-5 17 Jul 2023

Thanks for catching that, it was actually a bug.
Fixed.

UI-DEN-15279-5 17 Jul 2023

condistion -> condition

HD-DENBUG-64-1 18 Jul 2023

Done

HD-DENBUG-64-1 18 Jul 2023

You are stopping trimmer heater. Since DPi is running, you need to start the trimmer heater.

UI-DEN-15833-2 18 Jul 2023

Code Reviews are done:

Application: http://devapps.diality.us:8060/cru/UI-DEN-15279-1

Scripts: http://devapps.diality.us:8060/cru/UI-DEN-15279-5

ClousSync: http://devapps.diality.us:8060/cru/CLOUDSYNC-DEN-15279-1
The related build is in:

X:\Engineering\Denali\18-Software_Releases\DEN_UI\v0.6_P-BETA_V3\staging\2023-07-18T035448.785-0700_Release_v0.6.2-162-Passed

HD-DEN-15839-1 25 Jul 2023

RESOLVED IN CODE WALKTHROUGH

LEAHI-DIALIN-LEAH-139-2 25 Nov 2024

It's under priority task.

HD-DEN-15536-1 24 Jul 2023

RESOLVED IN CDOE WALKTHROUGH

HD-DEN-15536-1 21 Jul 2023

Add endTreatmentRequested

HD-DEN-15664-1 24 Jul 2023

RESOLVED in CODE WALKTHROUGH.

UI-DEN-15896-1 24 Jul 2023

We should check with Behrouz, but I think we should comment out the entire item instead of just the text property because the Text item still takes up space. For this case, we didn't define a fixed width, but if we did, there will be a gap.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

removed this and moved to QML

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

this connection has been removed

UI-DEN-15833-1 25 Jul 2023

[~msuleiman],
thanks for the comment.
this is fine to be consistent with the rest of the models, which are organized this way.

HD-DEN-15918-1 26 Jul 2023

Thank you, fixed.

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

moved this logic in the HeaderBarPopup component

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

RESOLVED

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Done.

LEAHI-APPLICATION-LDT-1788-1 12 Aug 2025

http://devapps.diality.us:8060/cru/#LEAHI-APPLICATION-LDT-1788-1CFR-69642

LEAHI-APPLICATION-LDT-2071-1 03 Sep 2025

RESOLVED

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

They are added

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

added FP flag and public get function

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-15702-1 12 Jul 2023

Corrected.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

I would need some help with this.

LEAHI-DIALIN-LDT-3479-1 12 Feb 2026

Removed

DG-DEN-14316-1 20 Dec 2022

removed

UI-DEN-15279-1 17 Jul 2023

Not clear what needs be addressed here?

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-236-1 12 Nov 2024

Done.

DD-LEAH-236-1 13 Nov 2024

Done.

DG-DEN-15842-1 20 Jul 2023

It's not a fault though. User can choose to resume, rinseback or end tx but will the alarm just trigger again immediately if you haven't resolved the h/w problem? With the 2 properties set to TRUE, user can choose to rinseback or end tx and they will not be bothered by this alarm again until rinseback and post-tx are completed.