•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-15660-1 12 Jul 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14307-1 20 Dec 2022

Agree, though this comment belongs in NVDataMgmt.c where setServiceTime() is lives. That function should return TRUE if successful.

DG-DEN-15660-1 12 Jul 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

removed

HD-DEN-15536-1 21 Jul 2023

Add endTreatmentAlarmResponseRequest and sendLastTreatmentPeriodicData.

DG-DEN-15702-1 12 Jul 2023

Remove gap before "=" as alignment no longer relevant.

RO-LEAH-244-1 06 Nov 2024

Will resolve in next branch.

UI-DEN-15905-2 24 Jul 2023

RESOLVED

DG-DEN-14316-1 20 Dec 2022

I'll assume this has been fixed but not pushed since it still shows up here.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

UI-DEN-15905-2 24 Jul 2023

RESOLVED

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14307-1 21 Dec 2022

Done

LEAHI-DIALIN-LEAH-136-2 04 Nov 2024

No HD in Leahi. Change to TD.

DG-DEN-14307-1 21 Dec 2022

Done

DG-DEN-14307-1 21 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

Does not appear to be referenced.

DG-DEN-14307-1 20 Dec 2022

Should not be able to transition from fault to either new mode.

DG-DEN-14307-1 20 Dec 2022

This message clearly has a payload - we should check payload length to be whatever it is.

UI-DEN-15896-1 24 Jul 2023

RESOLVED

DG-DEN-14307-1 21 Dec 2022

These two variables are local.

CLOUDSYNC-DEN-15279-1 14 Jul 2023

Did you intentionally leave this commented out?

HD-DEN-14344-3 21 Dec 2022

Need function header.

UI-DEN-15279-1 17 Jul 2023

"situaltoins" -> "situations"

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-15279-1 17 Jul 2023

"availabel" => "available"

DIALIN-DEN-14344-1 22 Dec 2022

RESOLVED.

UI-DEN-15279-1 17 Jul 2023

Need to change to match the function name

UI-DEN-15279-5 17 Jul 2023

Applicaion - > Application

UI-DEN-15279-5 17 Jul 2023

FOUNT -> FOUND ?

UI-DEN-15896-1 24 Jul 2023

Do we need to do this? The previous text binding had the "pairedAddr" in it.

RO-LEAH-244-1 05 Nov 2024

Correct. Removed the code.

HD-DENBUG-64-1 18 Jul 2023

Done

SCRIPTS-DEN-2793-2 18 Jul 2023

this CR is to old and obsolete.

HD-DENBUG-64-1 18 Jul 2023

We are assuming blood pump was already stopped and VBA/VBV were closed by first blood leak alarm?

Also, since dialysate pump is on, need to start trimmer heater.

RO-LEAH-244-1 05 Nov 2024

Done

HD-DEN-15918-1 26 Jul 2023

Thank you, fixed.

RO-LEAH-244-1 05 Nov 2024

Done

RO-LEAH-244-1 05 Nov 2024

Done

RO-LEAH-244-1 04 Nov 2024

HD -> TD.

RO-LEAH-244-1 04 Nov 2024

No CPLD for RO?

DIALIN-DEN-17093-1 06 Nov 2024

There two new variables added.

RO-LEAH-244-1 06 Nov 2024

Fixed.

RO-LEAH-244-1 04 Nov 2024

= 0 on first enum.

RO-LEAH-244-1 06 Nov 2024

Referring to RO alarms as RO here. In properties table, RO faults will be marked as DD faults (from TD perspective, they kind of are DD faults).

RO-LEAH-244-1 06 Nov 2024

Will resolve in next branch.

DIALIN-DEN-17093-1 06 Nov 2024

RESOLVED.