•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 19 Dec 2022

Change both sizeof() calls to BOOL to match type of local var destination of your memcpy(). All are 4 bytes - just for consistency and in case BOOL gets changed.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

Remove blank line.

DG-DEN-14316-1 20 Dec 2022

I still see two /*@}/.

UI-DEN-14294-1 20 Dec 2022

Fixed the indentation

DG-DEN-14316-1 20 Dec 2022

Need an else at bottom (for not in idle standby mode) where we would set reject code to something like not in correct mode (I'm sure we have a code for this already). And then move the send response functional call to very end of this function so that it will always send a response in any case.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

Remove blank lines.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

Still see two.

DG-DEN-14316-1 20 Dec 2022

Should these two lines be deleted?

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

UI-DEN-14294-1 20 Dec 2022

RESOLVED.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

Remove TODO and extra blank lines.

DG-DEN-14316-1 20 Dec 2022

Remove blank line.

DG-DEN-14497-1 01 Jan 2023

Should be removed?

DG-DEN-14497-1 01 Jan 2023

The description seems to be missing a few words.

DG-DEN-14497-1 01 Jan 2023

Add heaterStatus to header.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-15660-1 10 Jul 2023

Don't like "timeout" in this constant. It's not really a timeout. It's a sample time (or collection time if you prefer). Change TIMEOUT to TIME.

RO-LEAH-244-1 02 Nov 2024

Where can I find the changes?

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

Remove blank line.

DG-DEN-15660-1 12 Jul 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.