•  

Comment Results

Review Name Created Custom Fields Content
HD-DENBUG-64-1 18 Jul 2023

Done

HD-DEN-15839-1 25 Jul 2023

Where is the heater turned back on? Is the state saved?

UI-DEN-15905-2 21 Jul 2023

The file name is missing "ck" for the back. I don't believe you did that on purpose ?

UI-DEN-15905-2 21 Jul 2023

Please remove empty space.

DD-LEAH-236-1 08 Nov 2024

Is this initial increment needed? The exec function increments this counter.

HD-DEN-15918-1 26 Jul 2023

Alignment

DD-LEAH-236-1 11 Nov 2024

Will handle in next revision. created a placeholder.

DD-LEAH-236-1 11 Nov 2024

Updated.

DD-LEAH-236-1 11 Nov 2024

Done.

DD-LEAH-236-1 08 Nov 2024

What are units for this frequency? Looks like switches per minute?
Does anybody need this?

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

Added missing space

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-15799-1 07 Jul 2023

Noted: I must have selected it by mistake

HD-DEN-17093-1 01 Nov 2024

Added another state to check the extra volume.

UI-DEN-15279-5 17 Jul 2023

RESOLVED

HD-DEN-17093-1 01 Nov 2024

Removed the reset function.

DG-DEN-15660-1 12 Jul 2023

Done

HD-DEN-17093-1 31 Oct 2024

Should be 2 blank lines above test support banner.

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

Removed FPcommon.h

DG-DEN-15660-1 12 Jul 2023

Nelson support is only in debug mode.

RO-LEAH-244-1 02 Nov 2024

Done

DG-DEN-15660-1 12 Jul 2023

Done

LEAHI-DD-FIRMWARE-LDT-2198-1 16 Sep 2025

fixed. thanks

DG-DEN-15660-1 12 Jul 2023

Done

HD-DEN-15556-1 12 Jul 2023

Done.

DG-DEN-15660-1 11 Jul 2023

What about acid?

RO-LEAH-244-1 02 Nov 2024

It was a mistake. Done.

HD-DEN-15556-1 12 Jul 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15556-1 11 Jul 2023

Add cartrideUsedTestRun

LEAHI-APPLICATION-LDT-1616-1 24 Sep 2025

RESOLVED

HD-DEN-15556-1 12 Jul 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15660-1 12 Jul 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15702-1 11 Jul 2023

Correct indentation

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

updated and moved these into wifiInfoRequest()

DG-DEN-15702-1 12 Jul 2023

RESOLVED IN CODE WALKTHROUGH

LEAHI-APPLICATION-LDT-1616-1 24 Sep 2025

RESOLVED

HD-DEN-15660-1 13 Jul 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

This has been reverted back to original

HD-DENBUG-64-1 18 Jul 2023

See the "also" in my comment above.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

update to bind ssid to this and moved location at the top of the info list

HD-DENBUG-64-1 19 Jul 2023

Done

LEAHI-DIALIN-LDT-2300-1 25 Sep 2025

Done

HD-DEN-15628-1 17 Jul 2023

Done.

CLOUDSYNC-DEN-15279-1 15 Jul 2023

It is not my code.
But according to the conversations we had with Radu from KeborMed, some of the Error handlings left as a comment for later implementation.

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

Thanks Nico!
RESOLVED.

UI-DEN-15279-1 17 Jul 2023

It has been added.

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

these are still relevant for the DD to call requestFPGeneratePermeate()

UI-DEN-15279-1 17 Jul 2023

the error will be visible to user and needs to be addressed if can not be resolved.
In normal operation it is not expected to happen, and if happens, it is a FS issue.

UI-DEN-15279-1 17 Jul 2023

Added

LEAHI-DIALIN-LDT-2300-1 25 Sep 2025

Done