•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15763-1 05 Jul 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 19 Dec 2022

Align.

HD-DEN-15763-1 30 Jun 2023

Add dgStartCommandSent, dgCurrentOpMode, dgStarted

DG-DEN-14316-1 20 Dec 2022

Removed the do nothing cases, added comment to default case.

DG-DEN-14316-1 19 Dec 2022

Keep blank line before return statement.

DG-DEN-14316-1 19 Dec 2022

Can these 2 declarations be moved up with the others (above "ifndef_RELEASE_")?

DG-DEN-14316-1 19 Dec 2022

Should have a default case with s/w fault or something.

DG-DEN-14316-1 19 Dec 2022

Ok to not do anything for these cases, but put a comment in here so we know this is intentional.

DG-DEN-14316-1 19 Dec 2022

DGChemicalDisinfectFlushMode

HD-DEN-14344-3 19 Dec 2022

Need function header.

DIALIN-DEN-14344-1 19 Dec 2022

Need function header.

DIALIN-DEN-14344-1 19 Dec 2022

Add Publish list.

HD-DEN-15272-1 22 Jun 2023

I simplified it. Now if fails, test ends. If passed ( < 3 errors), PASS result is set on exit with Complete state.

UI-DEN-15799-1 07 Jul 2023

Thank you.
RESOLVED

HD-DEN-15773-1 29 Jun 2023

Checking the accuracy of the RTC to cpu ms time was removed. The accuracy of the cpu ms time is checked against the FPGA ms time. The RTC time is verified against the FPGA ms time.

UI-DEN-15785-16 07 Jul 2023

Please always take care of the code alignment, as you have already done here.

HD-DEN-15763-1 07 Jul 2023

Done.

UI-DEN-15799-1 07 Jul 2023

Thanks,
RESOLVED

HD-DEN-15763-1 09 Jul 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15763-1 07 Jul 2023

Update header: dopRateCorrectionOffset, offsetPWMDutyCyclePct, dopRateCorrectionOffset. dopControlSignal, dialOutPumpControlMode, dialOutPumpState

HD-DEN-15763-1 10 Jul 2023

Done.

HD-DEN-15763-1 10 Jul 2023

Add flowFilterTimerCtr, ufCalcTimerCtr

DG-DEN-15660-1 10 Jul 2023

Can we move these declarations up to top of scope?

HD-DEN-15756-1 11 Jul 2023

Why is this necessary? This doesn't seem to have anything to do with DEN-15756 - which is fine - but then I'm wondering what's driving this change.

HD-DEN-15716-1 11 Jul 2023

Fixed. Thanks!

DG-DEN-15660-1 10 Jul 2023

Is this really a timeout? Or is it a minimum duration?

HD-DEN-15556-1 11 Jul 2023

Add confirmInstallRequested to header

DG-DEN-15660-1 12 Jul 2023

Done

DG-DEN-15660-1 12 Jul 2023

Done

DG-DEN-15660-1 12 Jul 2023

Done

DG-DEN-15660-1 12 Jul 2023

This is a time and not timeout.

DG-DEN-15660-1 12 Jul 2023

Done

DG-DEN-15660-1 12 Jul 2023

Done

DG-DEN-15660-1 12 Jul 2023

Done

DG-DEN-15660-1 12 Jul 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15556-1 11 Jul 2023

Update header

DG-DEN-15660-1 11 Jul 2023

This looks strange. If we have a empty bottle alarm, shouldn't we just not start a fill in the first place?
With this approach, you're just stuck in fill start state until user clears the alarm.

DG-DEN-15660-1 12 Jul 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15660-1 12 Jul 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15660-1 12 Jul 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15660-1 11 Jul 2023

handleEmptyBottleFlag is only an input

TD-LEAH-51-1 28 Oct 2024

Fixed.

LEAHI-DD-FIRMWARE-LDT-2198-1 16 Sep 2025

fixed. thanks

HD-DEN-15558-1 13 Jun 2023

Was temporary change for blood leak test. Restored original code.

HD-DEN-15367-1 06 Jun 2023

Add disinfectCancelReqID, currentStandbyState, currentDGCleaningMode

HD-DEN-15367-1 13 Jun 2023

Aligned, thanks.

HD-DEN-15558-1 13 Jun 2023

RESOLVED IN CODE WALKTHROUGH

DIALIN-DEN-15196-7 14 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.