•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-17093-1 21 Oct 2024

I thought we decided not to have the range anymore. Just a threshold crossing now. So > minimum drift only.

UI-DEN-15279-1 20 Jun 2023

Very minor, but do you want this to be "eError_No_SettingsFile" where settings is plural?

HD-DEN-15272-1 22 Jun 2023

I think I understand how this works now. Kind of confusing how this is done and strange to see passed set here when it just failed.
If I understand correctly, test must fail 3 out of the 5 tests to fail the whole test - otherwise it passes?

HD-DEN-15272-1 22 Jun 2023

state is already in progress - no need to reassign it here.
result is already in progress as well.

HD-DEN-17093-1 28 Oct 2024

Systems to provide appropriate debounce time based on max expected drift rate.

TD-LEAH-51-1 28 Oct 2024

Do we need this timeout to be changed as task interval counter as we were seeing additional 100ms debounce time at times (hence adjusted the requirement)?

TD-LEAH-51-1 29 Oct 2024

Fixed.

RO-LEAH-244-1 04 Nov 2024

FpgaRO

HD-DEN-17093-1 31 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 31 Oct 2024

Not really a range on upper side.

HD-DEN-17093-1 31 Oct 2024

Done

HD-DEN-17093-1 31 Oct 2024

Sending event here is problematic now that we will likely defer zeroing until reservoir switch. It will send every 50ms until we finally zero. Move this to location where we are actually going to zero OR just remove the event as its maybe no longer applicable.

HD-DEN-17093-1 31 Oct 2024

If a zero is requested, it is checked first and then this flag is reset. I also want this flag to be reset all the time so we do not zero on old reservoir.

RO-LEAH-244-1 02 Nov 2024

Done

RO-LEAH-244-1 04 Nov 2024

Done

HD-DEN-17093-1 31 Oct 2024

Add a comment explaining we are resetting drift in range debounce timer if we are not in drift range.

RO-LEAH-244-1 04 Nov 2024

Done

HD-DEN-17093-1 04 Nov 2024

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-244-1 04 Nov 2024

Done

RO-LEAH-244-1 30 Oct 2024

Need to have memsets to zero register structures.

RO-LEAH-244-1 05 Nov 2024

Done

RO-LEAH-244-1 05 Nov 2024

Done

RO-LEAH-244-1 30 Oct 2024

Remove all POST tests that look like HD POST tests for now. Since we're not doing any POST tests initially, we don't need to worry too much about this enum yet.

RO-LEAH-244-1 30 Oct 2024

Why are you changing these? This is TD code.

RO-LEAH-244-1 06 Nov 2024

Will resolve in next branch.

UI-DEN-17098-1 08 Nov 2024

RESOLVED

DD-LEAH-236-1 11 Nov 2024

Done

HD-DEN-17093-1 22 Oct 2024

That doesn't answer my question.

DG-DEN-15367-1 13 Jun 2023

Done

DG-DEN-15367-1 13 Jun 2023

Done

DG-DEN-14316-1 19 Dec 2022

Add blank line between declarations and code.

DIALIN-DEN-14307-1 19 Dec 2022

Can these fields be a value that is not 0 or 1? Seems weird to have them be unpacked and casted as a bool only to have the override parameters have int instead of bool.

DG-DEN-14316-1 19 Dec 2022

Prefer to have declarations of local variables at top of scope where they are used.

DG-DEN-15367-1 13 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15558-1 13 Jun 2023

RESOLVED in CODE WALKTHROUGH.

UI-DEN-14294-1 19 Dec 2022

This function is a slot to debug the behavior of the power dialog for now
The entire qml file may later be removed.
We had some conversations to combine the power message into confirmation and remove the power qml, models, and so on.

UI-DEN-15279-1 14 Jun 2023

RESOLVED

DG-DEN-14316-1 19 Dec 2022

..CHEM_DISINFECT_FLUSH_INVALID_EXEC_STATE

DG-DEN-14316-1 19 Dec 2022

Align.

DG-DEN-14316-1 19 Dec 2022

Align.

UI-DEN-15279-1 05 Jun 2023

"nned" -> "need"

This comment should be revised to be clearer. It's not entirely clear what we mean here.

DG-DEN-14316-1 19 Dec 2022

Align = or bring next to state.

HD-DEN-14007-1 19 Dec 2022

UPDATED IN CODE WALKTHROUGH.

DG-DEN-14316-1 19 Dec 2022

Remove extra blank line.

DIALIN-DEN-15196-7 14 Jun 2023

Fixed. Thanks!

DG-DEN-14316-1 19 Dec 2022

Does "tank" refer to reservoir? Prefer reservoir if so.

DIALIN-DEN-15196-7 14 Jun 2023

Align comment.

DG-DEN-14316-1 19 Dec 2022

Remove blank line.

DG-DEN-14316-1 19 Dec 2022

Check indents.

DG-DEN-14316-1 19 Dec 2022

Remove blank line.