No DG in Leahi. Change to DD.
Done
These are TD modes. RO initially needs fault, service (empty for now), init (no POST tests for now), standby, and delivery RO water modes.
Remove extra blank line.
looks RO not needing these.
Comment says TD. Should be RO.
This state, when used, appears to delay start of next fill cycle by 50ms.
RESOLVED
Done.
Update to latest in staging branch.
RESOLVED in CODE WALKTHROUGH.
I don't see why we need the extra precision here. I suspect a 64-bit division is expensive (s/w library implementation instead of co-processor) so I don't like to use doubles unless it is truly necessary.
Looks already taken care.
RESOLVED IN CODE WALKTHROUGH
The authors and dates will be addressed automatically once the copyright script is run in staging build.
Isn't currentStandbyState an output?
Expecting to see added FP controllers executed from general task.
Do we need a stopHeaterSignal?
Why does trimmer heater have its own ramp and control states? I understand the functions may be different, but that can be handled in a shared state.
Removed the check to make sure the target speed is > 0. The current speed is always >= 0.0 mL/min.
Why doesn't the stopHeater function set state to off?
Should we change state to off state?
Are these settings just an example of a configuration? Should this file be part of code repo?
Should be absolute value (in case measMotorSpeedInRotorRPM is negative for reverse direction).
Remove comment and brackets.
Remove commented lines.
Remove code.
Add venLowPresExemptAfterAirTrapFillTimerCtr to header.
signall -> signal successfull -> successful
Update function header.
"accpeted" -> "accepted"
comment is too terse. describe better.
It is called in the translationToStandyMode in the function clearCurrentCleaningModeStatus().
Fixed. Thanks!
Yes. Changed to task interval based debounce timing.
Add comment that other cases are ignored because loop makes them impossible.
Comments are swapped.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
