•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-17093-1 31 Oct 2024

The variables have been removed and/or renamed

HD-DEN-15660-1 22 Jun 2023

Should this be removed? or just the comment?

UI-DEN-15279-1 22 Jun 2023

It appears that we are checking string fields of the ethernet driver and not performing a POST for the driver, is that being performed elsewhere ?, for example ethtool or similar

UI-DEN-15279-1 20 Jun 2023

I am just checking whether "NotExits" is what you intend or "NotExists" based on the removed log message.

DG-DEN-14253-1 05 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15367-1 13 Jun 2023

This function is only to set the actuators. If the incorrect message status is selected the collect sample function will trigger the software fault.

DG-DEN-15367-1 13 Jun 2023

Done

HD-DEN-14458-1 14 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-225-1 16 Oct 2024

startHeaterSignal used for both start and stop state handling.

DG-DEN-14307-1 19 Dec 2022

Update function header.

CS-BUILD-0-2-4-1 14 Dec 2022

Should be @return for our code documenting tool. Or is KBM using a different tool that uses this comment format?

DG-DEN-15367-1 13 Jun 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15367-1 13 Jun 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15367-1 13 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15558-1 13 Jun 2023

Done.

HD-DEN-15367-1 12 Jun 2023

Add bloodLeakPeristenceCtr.

UI-DEN-15279-1 05 Jun 2023

of -> if

HD-DEN-17093-1 21 Oct 2024

The zeroBloodLeak() only tries up to 3 calls and then alarms.

DG-DEN-15367-1 14 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 22 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15367-1 14 Jun 2023

RESOLVED in CODE WALKTHROUGH.

UI-DEN-17098-1 27 Oct 2024

No we do not need this code. I removed it.

HD-DEN-15436-1 14 Jun 2023

CLOSED in CODE WALKTHROUGH.

DIALIN-DEN-15196-7 14 Jun 2023

We need to display the last Saline event before we switch back.

Due to how we exit this state machine, we call transitionToDialysis() if we go to SALINE_BOLUS_STATE_MAX_DELIVERED which will update the substate back to the current UF state.

TD-LEAH-51-1 28 Oct 2024

Fixed.

TD-LEAH-51-1 28 Oct 2024

Remove 'a'.

HD-DEN-15282-1 26 Jun 2023

RESOLVED IN CODE WALKTHROUGH

RO-LEAH-244-1 30 Oct 2024

Remove this comment. Broadcast channel ok.

HD-DEN-15436-1 14 Jun 2023

Updated.

HD-DEN-15436-1 14 Jun 2023

Do we still need this condition? Door closed requirement may have been released in prior state. Doesn't seem like this is truly needed to move on from here.

RO-LEAH-244-1 04 Nov 2024

Looks BP are TD specific.

HD-DEN-15436-1 14 Jun 2023

I feel like this whole state should be removed. We are no longer doing de-prime. Removing state will mean Dialin must be updated to reflect new state list.

HD-DEN-15330-1 14 Jun 2023

I think we should be checking alarm condition instead of alarm active. Temperature may have come back into range (condition cleared) but user hasn't resumed to clear alarm (maybe stepped away for a minute).

HD-DEN-15436-1 14 Jun 2023

Add patientDisconnectHandled to header

HD-DEN-15330-1 15 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 31 Oct 2024

Move this too if you didn't already.

HD-DEN-15272-1 22 Jun 2023

Fixed.

HD-DEN-17093-1 01 Nov 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15272-1 22 Jun 2023

Removed.

HD-DEN-17093-1 01 Nov 2024

Done

HD-DEN-17093-1 04 Nov 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15272-1 22 Jun 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-DIALIN-LEAH-136-2 04 Nov 2024

I don't think we have any DD POST tests defined yet.

RO-LEAH-244-1 04 Nov 2024

TD actually.

DG-DEN-15660-1 26 Jun 2023

Add stateTrialCounter

DG-DEN-15660-1 26 Jun 2023

Add nelsonSupport

UI-DEN-15279-1 20 Jun 2023

Missing doxygen comment

UI-DEN-15279-1 20 Jun 2023

This comment is incorrect

UI-DEN-15279-1 22 Jun 2023

The comment " Exit code is not used", if case of a failure, what would be the state of the instrument ?

RO-LEAH-244-1 30 Oct 2024

If not done already, we will need to make changes to some of this in HalCoGEN and there may be some of these function calls here that are not needed for RO.