Comment Search

Defect Metrics

Statistics on the results
No defects in results

Search Criteria

Search for comments

Search Criteria

Project
Comment content
Review PermaId
After
Before
Comment Author
Search Type
Search Type:
Review State
Review State:
Metrics:
Metric Ranking
Metric Classification
Submit
  •  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15660-1 26 Jun 2023

Remove blank line.
TD-LEAH-51-1 28 Oct 2024

Fixed.
TD-LEAH-51-1 28 Oct 2024

Please align the comments into same column.
HD-DEN-15272-1 22 Jun 2023

Moved declarations to top of file.
UI-DEN-17098-1 24 Oct 2024

Could you please search for the 0x6C00 message ID in the Dry-Demo and update that too.
If you found it please do the same as we did for the 0x0900 and 0x0B00.

Also fix the dialin same as dry-demo.
HD-DEN-15272-1 22 Jun 2023

Value is overridden below if the test is repeated. If it is the last time through test, it needs to be set here as Pass/Fail based on Fail counter.
HD-DEN-15272-1 22 Jun 2023

Remove comment. Maybe move part about bumping to brief above.
HD-DEN-15272-1 22 Jun 2023

RESOLVED in CODE WALKTHROUGH.
RO-LEAH-244-1 30 Oct 2024

Need at least basic functionality (actuators to safe state) here.
HD-DEN-15272-1 22 Jun 2023

Why are we passing test here? I think if you pass here, you will not return and retry. Should leave result as in progress to keep the test going.
HD-DEN-15282-1 23 Jun 2023

Add endTreatmentAlarmResponseRequest, sendLastTreatmentPeriodcData to header.
HD-DEN-17093-1 01 Nov 2024

RESOLVED in CODE WALKTHROUGH.
RO-LEAH-244-1 30 Oct 2024

I guess technically we don't need the ';' for these macros. Delete ';' for all 3 stacks throughout unit.
DG-DEN-15660-1 26 Jun 2023

Add nelsonSupport, stateTrialCounter to header.
DG-DEN-15660-1 26 Jun 2023

Update header.
RO-LEAH-244-1 30 Oct 2024

Change references to HD to TD.
DD-LEAH-225-1 16 Oct 2024

If a new target is set while in this state, are we just staying here and letting control handle the change?
DIALIN-DEN-14001-1 08 Dec 2022

first get function still missing header.
DG-DEN-15367-1 13 Jun 2023

Done
DIALIN-DEN-14001-1 08 Dec 2022

Please look at the green lines at the bottom of these comments
DD-LEAH-225-1 16 Oct 2024

Remove extra space before "=".
DIALIN-DEN-14001-1 08 Dec 2022

Done.
DG-DEN-15367-1 13 Jun 2023

This function will be overhauled.
LEAHI-TD-FIRMWARE-LDT-1903-8 24 Feb 2026

Use "F64" macro instead of double.
HD-DEN-17093-1 21 Oct 2024

Done
HD-DEN-14458-1 14 Dec 2022

RESOLVED in CODE WALKTHROUGH.
HD-DEN-15367-1 13 Jun 2023

RESOLVED IN CODE WALKTHROUGH
HD-DEN-17093-1 22 Oct 2024

RESOLVED in CODE WALKTHROUGH.
DG-DEN-15367-1 13 Jun 2023

RESOLVED in CODE WALKTHROUGH.
DG-DEN-15367-1 13 Jun 2023

Remove "handle" from this function name. It should start with "send". And why does this message have a payload. Message itself infers ready.
DG-DEN-14316-1 19 Dec 2022

This enum is not in a group. Assign it to one (existing or new).
DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.
CS-BUILD-0-2-4-1 12 Dec 2022

Update the code base in regards to the Diality Python coding standard.
To be included :
X:\Engineering\Denali\06- Software Design\Software Documentation\Coding Standards
SOP-0058, Software Coding Standards, Python, Rev. 01.docx
DG-DEN-14307-1 19 Dec 2022

Should this be removed?
HD-DEN-14007-1 19 Dec 2022

Function and State names updated.
HD-DEN-15330-1 15 Jun 2023

Looks like they do need to do the same thing. We should combine with condition above.
HD-DEN-14007-1 19 Dec 2022

Moved to module, initialized in mode init function.
HD-DEN-15330-1 15 Jun 2023

Combined. Thanks!
HD-DEN-14007-1 19 Dec 2022

Updated to hard stop function.
UI-DEN-15279-1 20 Jun 2023

It would be nice to be consistent on the casing of the messages, "YES" , "NO" or "Yes" / "No"
DIALIN-DEN-14316-1 19 Dec 2022

Remove blank line.
UI-DEN-15279-1 20 Jun 2023

missing doxygen comment
HD-DEN-14007-1 19 Dec 2022

RESOLVED IN CODE WALKTHROUGH.
UI-DEN-15279-1 20 Jun 2023

typo, "Continueing" -> "Continuing"
DG-DEN-14316-1 19 Dec 2022

Should not allow transition from fault mode to chem flush mode.
HD-DEN-15272-1 22 Jun 2023

RESOLVED in CODE WALKTHROUGH.
UI-DEN-14294-1 19 Dec 2022

Seems like as part of modern C++ the equal operator is no longer needed.
I need to investigate more to completely remove it.
DG-DEN-14316-1 19 Dec 2022

Add blank line between declarations and code.
DG-DEN-14316-1 19 Dec 2022

Add blank line between declaration and code.
HD-DEN-15272-1 23 Jun 2023

RESOLVED in CODE WALKTHROUGH.