•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-14316-1 19 Dec 2022

Body start bracket indented too far.

DG-DEN-14316-1 19 Dec 2022

Align comment.

DG-DEN-14316-1 19 Dec 2022

Align "="s.

UI-DEN-14294-1 19 Dec 2022

RESOLVED.

DIALIN-DEN-14344-1 19 Dec 2022

RESOLVED.

HD-DEN-14344-3 22 Nov 2022

How would you check motor is running? Not clear to me that we need a monitor. Can move broadcast to control exec.

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 22 Nov 2022

Not sure how we would test pump other than in pre-treatment when we do pressure leak test (bad pump will fail to pressurize venous side). Remove function unless there is some way to test pump directly.

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 19 Dec 2022

Should be a group ending /*@}/ at bottom here.

HD-DEN-14344-3 19 Dec 2022

Keep a blank line before return statement.

HD-DEN-14344-3 19 Dec 2022

Agree not necessary, but also no harm. This may have been done in response to a code review comment in early days.

DG-DEN-14316-1 20 Dec 2022

I can't see this in Code Composer Studio.

HD-DEN-14007-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 19 Dec 2022

Why are there two of these? /*@}/

DG-DEN-14316-1 19 Dec 2022

Check indent.

DG-DEN-14316-1 19 Dec 2022

Remove blank line.

DG-DEN-14316-1 19 Dec 2022

Remove blank line.

DG-DEN-14316-1 19 Dec 2022

File header?

HD-DEN-14007-1 20 Dec 2022

These should be moved to init function (which is called by this function).

DG-DEN-14316-1 19 Dec 2022

Has this been decided yet?

DG-DEN-14316-1 19 Dec 2022

Prefer local var declarations to be at top of scope where they're used.

DG-DEN-14316-1 19 Dec 2022

Does this enum belong in UIUserConfirm group above or some other group? I don't see a group header to capture this enum.

HD-DEN-14344-3 19 Dec 2022

Other than the fact that it was previously done, why use the parenthesis?

HD-DEN-14344-3 19 Dec 2022

If we're using air pump (nominal case), we don't need to defer DG fills anymore - can signal these wherever we used to start filling before we added this delay.

HD-DEN-14344-3 19 Dec 2022

Indent 2nd and 3rd line of if by 2 more spaces.

HD-DEN-14344-3 19 Dec 2022

Keep blank line between declaration and code and between code and return statement.

DIALIN-DEN-14344-1 19 Dec 2022

Isn't this function already declared in air_trap.py?

HD-DEN-14344-3 19 Dec 2022

Capitalize Level and Ctr. Add doxygen comment.

HD-DEN-14344-3 19 Dec 2022

How does the getAirPumpMotorState() give a T/F for alarm detection?

DG-DEN-14316-1 19 Dec 2022

Disagree. This is ModeFlush.c. Looks correct in last commit.

DG-DEN-15367-1 13 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 22 Oct 2024

RESOLVED in CODE WALKTHROUGH.

UI-DEN-15279-1 14 Jun 2023

RESOLVED

UI-DEN-15279-1 05 Jun 2023

"enditable" < Not sure if you meant "editable" here.

UI-DEN-15279-1 14 Jun 2023

RESOLVED

HD-DEN-17093-1 28 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15330-1 15 Jun 2023

Fixed. Thanks!

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15330-1 15 Jun 2023

Fixed. Thanks!

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15683-1 21 Jun 2023

Removed

DG-DEN-14316-1 20 Dec 2022

I can't see this in Code Composer Studio.

UI-DEN-14294-1 20 Dec 2022

RESOLVED.

HD-DEN-14007-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15763-1 05 Jul 2023

Done.

HD-DEN-14007-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.