•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 22 Nov 2022

Remove space before "state".

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 22 Nov 2022

Put constant on right side of compare operator. State should be < num of states.

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15330-1 14 Jun 2023

If you search for where execReservoirs() is called, you will see that it's already called by ModeTreatment.c right before this function is called.

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 22 Nov 2022

Remove extra blank line.

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15330-1 15 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15330-1 16 Jun 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 19 Dec 2022

Align.

DG-DEN-15683-1 21 Jun 2023

Done.

UI-DEN-14294-1 20 Dec 2022

RESOLVED.

DG-DEN-15647-1 21 Jun 2023

Done

HD-DEN-14099-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-15530-9 21 Jun 2023

[~vduong],
This CR is done and the branch is merged into staging.
Please close the branch at your earliest convenience.

HD-DEN-14007-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14007-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14007-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-15785-16 07 Jul 2023

Noted, and taken care of

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 19 Dec 2022

Align else body brackets.

DG-DEN-14316-1 19 Dec 2022

Alignment.

DG-DEN-15802-1 07 Jul 2023

Check alarm Ids 191, 192 in Heat Disinfect Active Cool

UI-DEN-15799-1 07 Jul 2023

Please do not include this file (denali.pro.user) in your commits.
I will soon remove it from the git tracking files, as soon as we are certain we don't need it anymore for unit testing.

DG-DEN-14316-1 20 Dec 2022

I am still not sure where you want the declarations to go. They are just before the part of the function that checks the inlet water conditions. The only other logical place is at the top.

DG-DEN-14316-1 19 Dec 2022

Align "="s.

DG-DEN-14316-1 19 Dec 2022

"Flusht" - remove t at end of Flush.

UI-DEN-14294-1 20 Dec 2022

I don't see ending bracket for this if. Does this even build?

HD-DEN-14344-3 19 Dec 2022

Why are we not turning off the air pump here? I do not see any delay in open state where pump is turned off, so we are only delaying by 50 ms. And I don't see any reason why pump should be on while VBT is open.

HD-DEN-14344-3 19 Dec 2022

Add comment explaining what we're doing here.

DIALIN-DEN-14344-1 19 Dec 2022

Need class header.

DIALIN-DEN-14344-1 19 Dec 2022

Does HD need a compatibility rev too (like you added to DG)?

HD-DEN-15763-1 10 Jul 2023

currentReservoirVolume is local. Others done.

HD-DEN-15763-1 10 Jul 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15702-1 11 Jul 2023

Correct indentation

DG-DEN-15660-1 12 Jul 2023

Nelson is not part of the commercial code.

DG-DEN-15660-1 12 Jul 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15660-1 12 Jul 2023

TRo needs comment for doxygen.

DG-DEN-15660-1 10 Jul 2023

Replace "TIMEOUT" with "TIME"

DG-DEN-15660-1 12 Jul 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15716-1 11 Jul 2023

The 2 verify states are single pass. I don't think it makes sense to return to them. They either pass or you go to fault mode and so you wouldn't even be here - so I think you can assume you passed.
For first displacement verify state, I think you should go to second displacement setup state.
For second displacement verify state, I think you should go to complete state.

DG-DEN-15608-1 12 Jul 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15702-1 12 Jul 2023

Corrected.

DG-DEN-15702-1 11 Jul 2023

Indentation needs to be corrected.