•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15660-1 13 Jul 2023

Done.

LEAHI-TD-FIRMWARE-LDT-1903-8 24 Feb 2026

Add blank line before return.

UI-DEN-15785-16 07 Jul 2023

RESOLVED

UI-DEN-17098-1 28 Oct 2024

Please refer to: DRY-DEMO-DEN-17098-1

UI-DEN-15799-1 07 Jul 2023

comment has been removed

UI-DEN-15799-1 07 Jul 2023

Please remove the commented line.

HD-DEN-15664-1 24 Jul 2023

Removed overrides.

HD-DEN-15763-1 10 Jul 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15763-1 10 Jul 2023

Add currentReservoirVolume, minimumReservoirVolume, steadyVolumeCount

RO-LEAH-244-1 30 Oct 2024

This is not a test support function. Move up.

HD-DEN-15758-1 11 Jul 2023

Incorporated into HD-DEN-15660

DG-DEN-15660-1 12 Jul 2023

The un-averaged TDi and TRo are used for dialysate temperature checking and trimmer heater control I think we should keep them to be able to have a full picture if needed unless the CAN bus is really flooded.

HD-DEN-15556-1 12 Jul 2023

Done.

RO-LEAH-244-1 02 Nov 2024

Done

HD-DEN-15556-1 12 Jul 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-17093-1 31 Oct 2024

Add comment explaining what we are checking here.

DG-DEN-15660-1 12 Jul 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15660-1 12 Jul 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15660-1 26 Jun 2023

Update header: rsrvr2Status, isRsrveLeadking, chemDisinfectReservoirTime, isChemDisinfectTempAboveTarget, ischemDisinfectWarmupTargetReached (should be isChemDisinfectWarmupTargetReached).

DG-DEN-15660-1 10 Jul 2023

Swap first and TRo positions in enum. TRo should be first, then we add a first to mark it as first.

UI-DEN-15279-5 17 Jul 2023

this is a one time and the systemctl is used to disable the service.
I think that is sufficient for now.

HD-DEN-17093-1 01 Nov 2024

RESOLVED in CODE WALKTHROUGH.

UI-DEN-15279-5 17 Jul 2023

Ok,
RESOLVED

DG-DEN-15608-1 12 Jul 2023

It is only monitored when not in safe state. Reviewed with Blaine.

DG-DEN-15702-1 12 Jul 2023

Corrected.

DG-DEN-15702-1 12 Jul 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15702-1 13 Jul 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 01 Nov 2024

Not really all pumps are being stopped here. Just DPi and syringe (do we need to stop syringe pump?). We are also bypassing dialyzer here.

UI-DEN-15279-1 17 Jul 2023

if statement needs condition results needs to be surrounded by braces {} even for single line code

RO-LEAH-244-1 05 Nov 2024

Done

UI-DEN-15279-1 17 Jul 2023

RESOLVED

RO-LEAH-244-1 05 Nov 2024

Done

UI-DEN-15279-1 17 Jul 2023

added

RO-LEAH-244-1 30 Oct 2024

Can we just remove the commented out code?

UI-DEN-15279-1 17 Jul 2023

RESOLVED

UI-DEN-15279-1 17 Jul 2023

How does this affect the "clean up" code for when the disk space reaches a certain percentage?

RO-LEAH-244-1 04 Nov 2024

Change all of these to RO fault in entire file.

UI-DEN-15279-1 17 Jul 2023

RESOLVED

RO-LEAH-244-1 04 Nov 2024

TD specific.

UI-DEN-15279-1 17 Jul 2023

RESOLVED

RO-LEAH-244-1 30 Oct 2024

There needs to be actuator (write) and sensor (read) register map structures defined here.

UI-DEN-15279-1 17 Jul 2023

RESOLVED

UI-DEN-15279-5 17 Jul 2023

Continueing -> continuing

RO-LEAH-244-1 06 Nov 2024

Will resolve in next branch.

UI-DEN-15279-5 17 Jul 2023

RESOLVED

UI-DEN-15279-5 17 Jul 2023

Why did we remove the copyright header?

UI-DEN-15279-1 17 Jul 2023

Should use {} for if statement

UI-DEN-15279-5 17 Jul 2023

the setup.sh script is running in manufacturing setup mode which is completely running by root user.

UI-DEN-15279-5 17 Jul 2023

Fixed

UI-DEN-15279-5 17 Jul 2023

Do we need sudo here ? What user are we currently logged in as when we run this script ?