•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15282-1 26 Jun 2023

Done.

UI-DEN-15279-1 20 Jun 2023

"trasnlated" - > "translated"

DIALIN-DEN-14344-1 22 Nov 2022

pass?

HD-DEN-14344-3 22 Nov 2022

There are 2 available msg IDs above that should be used before adding new ones.

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 19 Dec 2022

I think you're stuck with what you last commanded. You might try the get to see if it works, but I think those only work for input pins.
RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

I searched this file for tabs and replaced them with 4 spaces. Please check your editor tab settings.
RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 19 Dec 2022

Align.

DG-DEN-14316-1 20 Dec 2022

To be clear, does this mean all of the local declarations should be at the beginning of the function?

UI-DEN-14294-1 19 Dec 2022

Align function bodies.

HD-DEN-14007-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 19 Dec 2022

Align.

DG-DEN-14316-1 20 Dec 2022

Not necessarily at top of function. If variables are only used in a smaller scope (e.g. an if body), they can be declared at the top of that scope. I prefer they not be declared in the middle of code unless there is a good reason (e.g. a dependency in assignment on code above).

DG-DEN-14316-1 20 Dec 2022

Fixed

DG-DEN-14316-1 19 Dec 2022

Add blank line between declarations and code.

DG-DEN-14316-1 19 Dec 2022

This already called in transition into this mode.

DG-DEN-14316-1 19 Dec 2022

Align = or bring back to state.

HD-DEN-14344-3 19 Dec 2022

Keep blank line between declaration and return statement.

HD-DEN-14344-3 19 Dec 2022

This new else if would not be necessary I think if the pump were just turned off on way out of closed state (my comment from closed state handler).

LEAHI-DD-FIRMWARE-LDT-2198-1 16 Sep 2025

fixed. removed m4 from dd side

DG-DEN-15367-1 13 Jun 2023

Done

UI-DEN-15279-1 14 Jun 2023

RESOLVED

HD-DEN-15367-1 14 Jun 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14344-3 22 Nov 2022

This pin is an output (or it should be), so I don't think a get function makes sense. Where is this function used?

HD-DEN-17093-1 21 Oct 2024

Added handlers for the state machine.

HD-DEN-17093-1 21 Oct 2024

Should be &&, not ||.

HD-DEN-15436-1 14 Jun 2023

I left it because DG modes are checked and thought it must be waiting for DG mode to sync before moving on. If not an issue, I can remove it.

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 19 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15272-1 22 Jun 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15571-4 15 Jun 2023

Done

DG-DEN-14316-1 20 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15330-1 15 Jun 2023

Don't need this include.

HD-DEN-14007-1 20 Dec 2022

Moved to Init.

DG-DEN-14316-1 19 Dec 2022

Add blank line before return statement.

DG-DEN-14316-1 19 Dec 2022

Alignment - why is "=" pushed out so far?

DG-DEN-14316-1 19 Dec 2022

Why are there two of these?

DIALIN-DEN-14307-1 19 Dec 2022

Does this message need a broadcast override for V&V?

HD-DEN-14344-3 19 Dec 2022

When you merge staging locally, please add your new alarm to the new table down here as well.

HD-DEN-14344-3 19 Dec 2022

I think we want one more blank line (should be 2 total) before TEST SUPPORT banner.

HD-DEN-17093-1 22 Oct 2024

Removed the state.

HD-DEN-17093-1 22 Oct 2024

Removed the static pointer.

HD-DEN-17093-1 22 Oct 2024

Why are you treating bloodLeakZeroingStatus as a pointer here?

UI-DEN-15279-1 22 Jun 2023

[~pvedantam]
The Ethernet POST is not a requirement, and if it fails UI will not fail the POST.

HD-DEN-17093-1 22 Oct 2024

I changed it to 4 seconds.

DG-DEN-15683-1 21 Jun 2023

Why have {} in cases?

HD-DEN-15272-1 22 Jun 2023

Prefer not to have local statics. Move to top of file.